Focus and open context menu on right click if unfocused (singerdmx#2477)

Co-authored-by: CatHood0 <[email protected]>

Author: tjarvstrand

CHANGELOG.md

@@ -12,7 +12,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
-* Removed unicode from `QuillText` element that causes weird caret behavior on empty lines [#2453](https://github.com/singerdmx/flutter-quill/pull/2453).
+* Remove unicode from `QuillText` element that causes weird caret behavior on empty lines [#2453](https://github.com/singerdmx/flutter-quill/pull/2453).
+* Focus and open context menu on right click if unfocused [#2477](https://github.com/singerdmx/flutter-quill/pull/2477).
 * Update QuillController `length` extension method deprecation message [#2483](https://github.com/singerdmx/flutter-quill/pull/2483).
 
 ## [11.0.0] - 2025-02-16

lib/src/editor/editor.dart

@@ -6,6 +6,7 @@ import 'package:flutter/foundation.dart';
 import 'package:flutter/gestures.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter/rendering.dart';
+import 'package:flutter/scheduler.dart';
 import 'package:flutter/services.dart';
 
 import '../common/utils/platform.dart';
@@ -557,6 +558,28 @@ class _QuillEditorSelectionGestureDetectorBuilder
     }
   }
 
+  /// onSingleTapUp for mouse right click
+  @override
+  void onSecondarySingleTapUp(TapUpDetails details) {
+    if (delegate.selectionEnabled &&
+        renderEditor != null &&
+        renderEditor!.selection.isCollapsed) {
+      renderEditor!.selectPositionAt(
+        from: details.globalPosition,
+        cause: SelectionChangedCause.longPress,
+      );
+    }
+
+    if (renderEditor?._hasFocus == false) {
+      _state._requestKeyboard();
+      SchedulerBinding.instance.addPostFrameCallback((_) {
+        super.onSecondarySingleTapUp(details);
+      });
+    } else {
+      super.onSecondarySingleTapUp(details);
+    }
+  }
+
   @override
   void onSingleLongTapStart(LongPressStartDetails details) {
     if (_state.configurations.onSingleLongTapStart != null) {

lib/src/editor/widgets/delegate.dart

@@ -199,10 +199,12 @@ class EditorTextSelectionGestureDetectorBuilder {
   /// onSingleTapUp for mouse right click
   @protected
   void onSecondarySingleTapUp(TapUpDetails details) {
-    // added to show toolbar by right click
-    if (checkSelectionToolbarShouldShow(isAdditionalAction: true)) {
-      editor!.showToolbar();
-    }
+    SchedulerBinding.instance.addPostFrameCallback((_) {
+      // added to show toolbar by right click
+      if (checkSelectionToolbarShouldShow(isAdditionalAction: true)) {
+        editor!.showToolbar();
+      }
+    });
   }
 
   /// Handler for [EditorTextSelectionGestureDetector.onSingleTapCancel].

test/bug_fix_test.dart

@@ -162,6 +162,9 @@ void main() {
           await tester.tap(find.byType(QuillEditor),
               buttons: kSecondaryButton, kind: device);
           await tester.pumpAndSettle();
+          while (find.byType(AdaptiveTextSelectionToolbar).evaluate().isEmpty) {
+            await tester.pumpAndSettle();
+          }
 
           // Verify custom widget shows
           expect(find.byType(AdaptiveTextSelectionToolbar), findsAny);