optimización consulta de permisos y grupos

Author: manusreload

modules/debugbar/src/Debugbar.php

@@ -101,7 +101,7 @@ public function __construct($args = null)
         $this->messages = $debugbar->getCollector('messages');
         $this->request = $debugbar->getCollector('request');
         $this->response = $debugbar->getCollector('response');
-        $this->controller = $debugbar->getCollector('controller');
+        // $this->controller = $debugbar->getCollector('controller');
         $this->exceptions = $debugbar->getCollector('exceptions');
         $this->errors = $debugbar->getCollector('errors');
 
@@ -118,7 +118,7 @@ public function getDebugbar()
 //            self::$debugbar->addCollector(new PhpInfoCollector());
 //            self::$debugbar->addCollector(new MessagesCollector());
 //            self::$debugbar->addCollector(new RequestDataCollector());
-            self::$debugbar->addCollector(new ControllerCollector());
+            // self::$debugbar->addCollector(new ControllerCollector());
             self::$debugbar->addCollector(new ResponseCollector());
 //            self::$debugbar->addCollector(new TimeDataCollector());
 //            self::$debugbar->addCollector(new MemoryCollector());
@@ -261,11 +261,11 @@ public function onPDOCreated(&$pdo)
     // TODO: see: (https://github.com/maximebf/php-debugbar/issues/330)
     public function onViewCreated(&$twig)
     {
-        if(!$this->getDebugbar()->hasCollector('twig'))
-        {
-            $twig = new TraceableTwigEnvironment($twig, $this->time);
-            $this->getDebugbar()->addCollector(new TwigCollector($twig));
-        }
+        // if(!$this->getDebugbar()->hasCollector('twig'))
+        // {
+        //     $twig = new TraceableTwigEnvironment($twig, $this->time);
+        //     $this->getDebugbar()->addCollector(new TwigCollector($twig));
+        // }
     }
 
     public function onMailTransport($mailer)

modules/group_permissions/src/EventReceiver.php

@@ -16,7 +16,11 @@
 
 class EventReceiver
 {
-
+    /**
+     * @param \GroupPage[] $cache 
+     */
+    private static $cache = [];
+    private static $groupsUserCache = [];
     public function beforeControllerRun($controller)
     {
         if($controller instanceof AuthController)
@@ -31,7 +35,7 @@ public function isUserAllowed($controller, $user)
 
     /**
      * @param $controller
-     * @param $user User
+     * @param \User $user
      * @return bool
      */
     public static function isGroupAllowed($controller, $user)
@@ -40,15 +44,17 @@ public static function isGroupAllowed($controller, $user)
         $config = $context->getConfig();
         $page = new Page();
         $page = $page->get_by_controller($controller)->getModel();
-        if($page->id > 0)
+        if($page instanceof Page && $page->id > 0)
         {
-            $group = new \Group();
-            $groupPages = new \GroupPage();
-            $groups = $group->getByUser($user);
+            $groups = self::getGroupsByUser($user);
             foreach($groups->getModels() as $group)
             {
-                $result = $groupPages->get(array('id_group' => $group->id, 'id_page' => $page->id));
-                if($result->count() > 0) return ALLOW_USER;
+                $result = self::isGroupPages($group->id, $page->id);
+                if($result) {
+                    return ALLOW_USER;
+                }
+                // $result = $groupPages->get(array('id_group' => $group->id, 'id_page' => $page->id));
+                // if($result->count() > 0) return ALLOW_USER;
             }
         }
         return isset($config['allowDefault'])?(!$config['allowDefault']?DISALLOW_USER:""):null;
@@ -58,4 +64,29 @@ public function getAdminControllers()
     {
         return 'GLFramework\Modules\GroupPermissions\groups';
     }
+
+    public static function getGroupsByUser($user) {
+        $user_id = $user->id;
+        $group = new \Group();
+        if(self::$groupsUserCache[$user_id]) {
+            return self::$groupsUserCache[$user_id];
+        }
+        self::$groupsUserCache[$user_id] = $group->getByUser($user);
+        return self::$groupsUserCache[$user_id];
+
+    }
+
+    public static function isGroupPages($id_group, $id_page) {
+        if(!self::$cache) {
+            $groupPages = new \GroupPage();
+            self::$cache = $groupPages->get_all()->getModels();
+        }
+        foreach (self::$cache as $key => $value) {
+            if($value->id_group == $id_group && $value->id_page == $id_page) {
+                return true;
+            }
+        }
+        return false;
+        
+    }
 }

src/Model/UserPage.php

@@ -28,6 +28,7 @@
 
 use GLFramework\Controller;
 use GLFramework\Model;
+use GLFramework\ModelResult;
 
 /**
  * Class UserPage
@@ -36,6 +37,7 @@
  */
 class UserPage extends Model
 {
+    private static $cache;
     var $id;
     var $id_user;
     var $id_page;
@@ -107,7 +109,17 @@ public function isAllowed($instance, $user)
      */
     public function getByPageUser($id_user, $id_page)
     {
-        return $this->get(array('id_user' => $id_user, 'id_page' => $id_page));
+        if(!self::$cache) {
+            self::$cache = $this->get_all();
+        }
+        $list = [];
+
+        foreach (self::$cache as $key => $value) {
+            if($value->id_user == $id_user && $value->id_page == $id_page) {
+                $list[] = $value;
+            }
+        }
+        return new ModelResult(UserPage::class, $list);
     }
 
     /**