fix(init) exits on error before erasing package.json (wix#1693)

Co-authored-by: Blake Friedman <[email protected]>
Co-authored-by: Yaroslav Serhieiev <[email protected]>

Author: 3 people

detox/local-cli/init.js

@@ -5,6 +5,8 @@ const mochaTemplates = require('./templates/mocha');
 const jestTemplates = require('./templates/jest');
 const log = require('../src/utils/logger').child({ __filename });
 
+let exitCode = 0;
+
 module.exports.command = 'init';
 module.exports.desc = 'Scaffold initial E2E test folder structure for a specified test runner';
 module.exports.builder = {
@@ -42,17 +44,19 @@ module.exports.handler = async function init(argv) {
         'HINT: Try running one of the commands above, look what it does, and take similar steps for your use case.',
       ].join('\n'));
   }
+
+  process.exit(exitCode); // eslint-disable-line
 };
 
 function createFolder(dir, files) {
   if (fs.existsSync(dir)) {
-    return log.error(`Failed to create ${dir} folder, because it already exists at path: ${path.resolve(dir)}`);
+    return reportError(`Failed to create ${dir} folder, because it already exists at path: ${path.resolve(dir)}`);
   }
 
   try {
     fs.mkdirSync(dir);
   } catch (err) {
-    return log.error({ err }, `Failed to create ${dir} folder due to an error:`);
+    return reportError({ err }, `Failed to create ${dir} folder due to an error:`);
   }
 
   for (const entry of Object.entries(files)) {
@@ -65,9 +69,8 @@ function createFile(filename, content) {
   try {
     fs.writeFileSync(filename, content);
     log.info(`Created a file at path: ${filename}`);
-  } catch (e) {
-    log.error(`Failed to create a file at path: ${filename}`);
-    log.error(e);
+  } catch (err) {
+    reportError({ err }, `Failed to create a file at path: ${filename}`);
   }
 }
 
@@ -91,7 +94,7 @@ function parsePackageJson(filepath) {
   try {
     return require(filepath);
   } catch (err) {
-    log.error(`Failed to parse package.json due to an error:\n${err.message}`);
+    reportError(`Failed to parse package.json due to an error:\n${err.message}`);
   }
 }
 
@@ -106,7 +109,7 @@ function savePackageJson(filepath, json) {
   try {
     fs.writeFileSync(filepath, JSON.stringify(json, null, 2) + '\n');
   } catch (err) {
-    log.error(`Failed to write changes back into package.json due to an error:\n${err.message}`);
+    reportError(`Failed to write changes back into package.json due to an error:\n${err.message}`);
   }
 }
 
@@ -117,10 +120,16 @@ function patchDetoxConfigInPackageJSON({ runner }) {
     log.info(`Patching package.json at path: ${packageJsonPath}`);
 
     const packageJson = parsePackageJson(packageJsonPath);
-    loggedSet(packageJson, ['detox', 'test-runner'], runner);
-
-    savePackageJson(packageJsonPath, packageJson);
+    if (packageJson) {
+      loggedSet(packageJson, ['detox', 'test-runner'], runner);
+      savePackageJson(packageJsonPath, packageJson);
+    }
   } else {
-    log.error(`Failed to find package.json at path: ${packageJsonPath}`);
+    reportError(`Failed to find package.json at path: ${packageJsonPath}`);
   }
 }
+
+function reportError(...args) {
+  log.error(...args);
+  exitCode = 1;
+}