Skip to content

Commit a8cf46b

Browse files
authored
Moving locale setting from debug to normal images. This was causing uneven behaviour. Fixes SeleniumHQ#657 (SeleniumHQ#716)
1 parent b244466 commit a8cf46b

File tree

2 files changed

+22
-14
lines changed

2 files changed

+22
-14
lines changed

NodeBase/Dockerfile.txt

Lines changed: 22 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,34 @@
11
USER root
22

33
#==============
4-
# VNC and Xvfb
4+
# Xvfb
55
#==============
66
RUN apt-get update -qqy \
77
&& apt-get -qqy install \
8-
locales \
98
xvfb \
109
&& rm -rf /var/lib/apt/lists/* /var/cache/apt/*
1110

11+
#==============================
12+
# Locale and encoding settings
13+
#==============================
14+
ENV LANG_WHICH en
15+
ENV LANG_WHERE US
16+
ENV ENCODING UTF-8
17+
ENV LANGUAGE ${LANG_WHICH}_${LANG_WHERE}.${ENCODING}
18+
ENV LANG ${LANGUAGE}
19+
# Layer size: small: ~9 MB
20+
# Layer size: small: ~9 MB MB (with --no-install-recommends)
21+
RUN apt -qqy update \
22+
&& apt -qqy --no-install-recommends install \
23+
language-pack-en \
24+
tzdata \
25+
locales \
26+
&& locale-gen ${LANGUAGE} \
27+
&& dpkg-reconfigure --frontend noninteractive locales \
28+
&& apt -qyy autoremove \
29+
&& rm -rf /var/lib/apt/lists/* \
30+
&& apt -qyy clean
31+
1232
#================
1333
# Font libraries
1434
#================

NodeDebug/Dockerfile.txt

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -8,18 +8,6 @@ RUN apt-get update -qqy \
88
x11vnc \
99
&& rm -rf /var/lib/apt/lists/* /var/cache/apt/*
1010

11-
#=================
12-
# Locale settings
13-
#=================
14-
ENV LANGUAGE en_US.UTF-8
15-
ENV LANG en_US.UTF-8
16-
RUN locale-gen en_US.UTF-8 \
17-
&& dpkg-reconfigure --frontend noninteractive locales \
18-
&& apt-get update -qqy \
19-
&& apt-get -qqy --no-install-recommends install \
20-
language-pack-en \
21-
&& rm -rf /var/lib/apt/lists/* /var/cache/apt/*
22-
2311
#=========
2412
# fluxbox
2513
# A fast, lightweight and responsive window manager

0 commit comments

Comments
 (0)