Spark.list: moved,removed call rendered()

Author: dgreensp

packages/spark/spark.js

@@ -872,6 +872,18 @@ Spark.list = function (cursor, itemFunc, elseFunc) {
   if (! renderer)
     cleanup();
 
+  // Called by `removed` and `moved` in order to cause render callbacks on
+  // parent landmarks.
+  // XXX This is not the final solution.  1) This code should be unified
+  // with the code in scheduleOnscreenSetup.  2) In general, lists are
+  // going to cause a lot of callbacks (one per collection callback).
+  // Maybe that will make sense if we give render callbacks subrange info.
+  var notifyParentsRendered = function () {
+    var walk = outerRange;
+    while ((walk = findParentOfType(Spark._ANNOTATION_LANDMARK, walk)))
+      walk.renderCallback.call(walk.landmark);
+  };
+
   // The DOM update callbacks.
   _.extend(callbacks, {
     added: function (item, beforeIndex) {
@@ -902,6 +914,8 @@ Spark.list = function (cursor, itemFunc, elseFunc) {
           Spark.finalize(itemRanges[atIndex].extract());
 
         itemRanges.splice(atIndex, 1);
+
+        notifyParentsRendered();
       });
     },
 
@@ -918,6 +932,8 @@ Spark.list = function (cursor, itemFunc, elseFunc) {
           itemRanges[newIndex].insertBefore(frag);
 
         itemRanges.splice(newIndex, 0, range);
+
+        notifyParentsRendered();
       });
     },
 

packages/templating/templating_tests.js

@@ -769,15 +769,15 @@ Tinytest.add("templating - #each render callback", function (test) {
   entries.remove({x:'a'});
   test.equal(buf, []);
   Meteor.flush();
-  test.expect_fail();
   test.equal(buf, ['<div>b</div><div>c</div><div>d</div>']);
   buf.length = 0;
 
   // moved/changed
   entries.update({x:'b'}, {$set: {x: 'z'}});
   test.equal(buf, []);
   Meteor.flush();
-  test.equal(buf, ['<div>c</div><div>d</div><div>z</div>']);
+  test.equal(buf, ['<div>c</div><div>d</div><div>z</div>',
+                   '<div>c</div><div>d</div><div>z</div>']);
   buf.length = 0;
 
   // test pure "moved"
@@ -816,7 +816,6 @@ Tinytest.add("templating - #each render callback", function (test) {
   Meteor.flush();
   test.equal(div.html().replace(/\s/g, ''),
              '<div>b</div><div>c</div><div>a</div>');
-  test.expect_fail();
   test.equal(buf, ['<div>b</div><div>c</div><div>a</div>']);
   buf.length = 0;