Skip to content

Commit 30ed98d

Browse files
committed
Actually test rails 5.2, fix version check on route helper
1 parent 0d2c46f commit 30ed98d

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

.travis.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ gemfile:
2929
- gemfiles/rails_4.2.gemfile
3030
- gemfiles/rails_5.0.gemfile
3131
- gemfiles/rails_5.1.gemfile
32+
- gemfiles/rails_5.2.gemfile
3233

3334

3435
matrix:
@@ -64,3 +65,9 @@ matrix:
6465
gemfile: gemfiles/rails_4.1.gemfile
6566
- rvm: 2.4.3
6667
gemfile: gemfiles/rails_4.2.gemfile
68+
- rvm: 2.2.8
69+
gemfile: gemfiles/rails_5.0.gemfile
70+
- rvm: 2.2.8
71+
gemfile: gemfiles/rails_5.1.gemfile
72+
- rvm: 2.2.8
73+
gemfile: gemfiles/rails_5.2.gemfile

lib/generators/graphql/install_generator.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ def create_folder_structure
109109
log :route, 'graphiql-rails'
110110
shell.mute do
111111
# Rails 5.2 has better support for `route`?
112-
if Rails::VERSION::STRING > "5"
112+
if Rails::VERSION::STRING > "5.2"
113113
route <<-RUBY
114114
if Rails.env.development?
115115
mount GraphiQL::Rails::Engine, at: "/graphiql", graphql_path: "/graphql"

0 commit comments

Comments
 (0)