Merge pull request rmosolgo#1543 from gauravtiwari/master

Use a default empty hash if no arguments supplied

Author: Robert Mosolgo

lib/graphql/schema/relay_classic_mutation.rb

@@ -27,10 +27,14 @@ class RelayClassicMutation < GraphQL::Schema::Mutation
 
       # Override {GraphQL::Schema::Mutation#resolve_mutation} to
       # delete `client_mutation_id` from the kwargs.
-      def resolve_mutation(kwargs)
+      def resolve_mutation(**kwargs)
         # This is handled by Relay::Mutation::Resolve, a bit hacky, but here we are.
         kwargs.delete(:client_mutation_id)
-        resolve(**kwargs)
+        if kwargs.any?
+          resolve(**kwargs)
+        else
+          resolve
+        end
       end
 
       resolve_method(:resolve_mutation)

spec/graphql/schema/relay_classic_mutation_spec.rb

@@ -35,4 +35,20 @@
       assert mutation.null
     end
   end
+
+  describe "execution" do
+    it "works with no arguments" do
+      res = Jazz::Schema.execute <<-GRAPHQL
+      mutation {
+        addSitar(input: {}) {
+          instrument {
+            name
+          }
+        }
+      }
+      GRAPHQL
+
+      assert_equal "Sitar", res["data"]["addSitar"]["instrument"]["name"]
+    end
+  end
 end

spec/support/jazz.rb

@@ -45,9 +45,9 @@ def self.data
   end
 
   class BaseArgument < GraphQL::Schema::Argument
-    def initialize(name, type, desc = nil, custom: nil, **kwargs)
+    def initialize(*args, custom: nil, **kwargs)
       @custom = custom
-      super(name, type, desc, **kwargs)
+      super(*args, **kwargs)
     end
 
     def to_graphql
@@ -446,12 +446,25 @@ def resolve(name:, family:, execution_errors:)
     end
   end
 
+  class AddSitar < GraphQL::Schema::RelayClassicMutation
+    null true
+    description "Get Sitar to musical instrument"
+
+    field :instrument, InstrumentType, null: false
+
+    def resolve
+      instrument = Models::Instrument.new("Sitar", :str)
+      { instrument: instrument }
+    end
+  end
+
   class Mutation < BaseObject
     field :add_ensemble, Ensemble, null: false do
       argument :input, EnsembleInput, required: true
     end
 
     field :add_instrument, mutation: AddInstrument
+    field :add_sitar, mutation: AddSitar
 
     def add_ensemble(input:)
       ens = Models::Ensemble.new(input.name)