Skip to content

Fix ollama client TODOs #5597

Open
@peterychang

Description

@peterychang

What feature would you like to be added?

Several TODOs in ollama client:

  • Add model families to directly supported models
  • Deduplicate code between openai, azure, and ollama model clients
  • Add argument checking
  • Handle message source parameters
  • Ensure token counting logic is correct
  • Ensure constants (eg: done_reason) are still correct
  • Check whether multiple content, images, and/or tools can/should exist within a single message
  • Confirm streaming mode works properly
  • Implement logprobs logic when it's added to the ollama client (see: Provide logits or logprobs in the API ollama/ollama#2415)

Why is this needed?

necessary to fully support the client

Metadata

Metadata

Assignees

Labels

modelsPertains to using alternate, non-GPT, models (e.g., local models, llama, etc.)size-largetakes 1-2 weeks

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions