Skip to content

fix(conda build): revert noarch and add playwright install test #2792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 31, 2025
Merged

fix(conda build): revert noarch and add playwright install test #2792

merged 6 commits into from
Mar 31, 2025

Conversation

cisaacstern
Copy link
Contributor

@cisaacstern cisaacstern commented Mar 18, 2025 •
edited
Loading

closes #2791

Starting by just adding the failing test case proposed by @mxschmitt in #2791 (comment) , to prove to ourselves that ci will fail with this additional test. Oops, ci doesn't run without maintainer approval, that makes sense!

I've gone ahead and implemented your proposed changes as best I understood them, @mxschmitt! Thanks for the prompt review and direction on this. Happy to adjust if you like, or feel free to push to this branch directly if you prefer. 🙏

@cisaacstern
Copy link
Contributor Author

@microsoft-github-policy-service agree

@cisaacstern cisaacstern marked this pull request as ready for review March 18, 2025 21:57
@cisaacstern cisaacstern mentioned this pull request Mar 18, 2025
Closed
@mxschmitt mxschmitt mentioned this pull request Mar 19, 2025
Closed
@mxschmitt
Copy link
Member

What I'm still confused a bit about is why #2794 is still passing - do you have a clue why this is the case?

@cisaacstern
Copy link
Contributor Author

why #2794 is still passing

meaning, why the ubuntu build is failing both here and on #2794? yeah that's a little bit odd ... not sure off the top of my head, will think about that for a moment 🤔

@cisaacstern
Copy link
Contributor Author

I wonder if the Github Actions ubuntu runner perhaps just doesn't have the necessary browser dependencies (I have seen something like this elsewhere). I will try with --with-deps.

@cisaacstern
Copy link
Contributor Author

@mxschmitt it seems this needs your approval to re-run. When you get a moment, could we try the latest change, either here or on #2794, if that's easier?

@cisaacstern
Copy link
Contributor Author

😕 Well shucks. I can try actually building this locally in an Ubuntu container, to reproduce this error. Will check back with any findings.

@cisaacstern
Copy link
Contributor Author

Update: I have been able to repro this locally. Will follow up shortly with a fix.

@cisaacstern
Copy link
Contributor Author

@mxschmitt thanks for jumping in here. I was able to repro the prior error on an ubuntu container, but couldn't figure out how to fix it 🤷

@mxschmitt mxschmitt merged commit 2da9003 into microsoft:main Mar 31, 2025
37 of 38 checks passed
@cisaacstern
Copy link
Contributor Author

Thanks @mxschmitt!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: playwright install is broken when installing 1.51.0 from microsoft conda channel
2 participants
@cisaacstern @mxschmitt