Skip to content

Commit 7a77a30

Browse files
author
rubyist
committed
Display any errors when creating the CopyCallbackFile
1 parent f951e3e commit 7a77a30

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

lfs/upload_queue.go

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,10 @@ func NewUploadable(oid, filename string, index, totalFiles int) (*Uploadable, *W
3333
return nil, Errorf(err, "Error uploading file %s (%s)", filename, oid)
3434
}
3535

36-
cb, file, _ := CopyCallbackFile("push", filename, index, totalFiles)
37-
// TODO: fix this, Error() is in `commands`. This is not a fatal error, it should display
38-
// but not return.
39-
// if cbErr != nil {
40-
// Error(cbErr.Error())
41-
// }
36+
cb, file, cbErr := CopyCallbackFile("push", filename, index, totalFiles)
37+
if cbErr != nil {
38+
fmt.Fprintln(os.Stderr, cbErr.Error())
39+
}
4240

4341
if file != nil {
4442
defer file.Close()

0 commit comments

Comments
 (0)