Skip to content

Commit 6eba0ce

Browse files
mcomellamergify[bot]
authored andcommitted
For fenix#17451: add comment warning about Log.Priority.VERBOSE.
The reason we did this is mentioned in mozilla-mobile#9451 (comment) as: > To limit the options to an accepted subset. (We also did not add the > ASSERT level). For a satisfying answer, I think we'd need to ask "Why?" again. However, I don't want to spend more time on this so I didn't follow up on it. This is why I didn't mention any reasoning for this in the code comment.
1 parent d7f2692 commit 6eba0ce

File tree

1 file changed

+3
-0
lines changed
  • components/support/base/src/main/java/mozilla/components/support/base/log

1 file changed

+3
-0
lines changed

components/support/base/src/main/java/mozilla/components/support/base/log/Log.kt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,9 @@ object Log {
100100
enum class Priority(val value: Int) {
101101
// For simplicity the values mirror the Android log constants values:
102102
// https://android.googlesource.com/platform/frameworks/base/+/refs/heads/master/core/java/android/util/Log.java
103+
//
104+
// We intentionally omit ASSERT and VERBOSE. If you change this,
105+
// be aware of the impact on consumers.
103106

104107
DEBUG(android.util.Log.DEBUG),
105108
INFO(android.util.Log.INFO),

0 commit comments

Comments
 (0)