[dartdev] tweak the help text for the pub and format commands

Change-Id: Id7b24e5866acf04b93973fc08d76dc93722a3173
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136321
Reviewed-by: Jaime Wren <[email protected]>
Commit-Queue: Devon Carew <[email protected]>

Author: devoncarew

pkg/dartdev/lib/src/commands/format.dart

@@ -9,10 +9,7 @@ import '../sdk.dart';
 
 class FormatCommand extends DartdevCommand {
   FormatCommand({bool verbose = false})
-      : super(
-          'format',
-          'Idiomatically formats Dart source code.',
-        ) {
+      : super('format', 'Format Dart source code.') {
     // TODO(jwren) When https://github.com/dart-lang/dart_style/issues/889
     //  is resolved, have dart_style provide the ArgParser, instead of creating
     // one here.

pkg/dartdev/lib/src/commands/pub.dart

@@ -24,8 +24,7 @@ import '../utils.dart';
 class PubCommand extends DartdevCommand<int> {
   var pubCommandRunner = PubCommandRunner();
 
-  PubCommand({bool verbose = false})
-      : super('pub', 'Pub is a package manager for Dart.') {
+  PubCommand({bool verbose = false}) : super('pub', 'Work with packages.') {
     argParser.addFlag('version', negatable: false, help: 'Print pub version.');
     argParser.addFlag('trace',
         help: 'Print debugging information when an error occurs.');

pkg/dartdev/test/commands/create_test.dart

@@ -12,10 +12,10 @@ import 'package:test/test.dart';
 import '../utils.dart';
 
 void main() {
-  group('create', defineCreate);
+  group('create', defineCreateTests);
 }
 
-void defineCreate() {
+void defineCreateTests() {
   TestProject p;
 
   setUp(() => p = null);

pkg/dartdev/test/commands/format_test.dart

@@ -22,7 +22,7 @@ void format() {
     var result = p.runSync('format');
     expect(result.exitCode, 0);
     expect(result.stderr, isEmpty);
-    expect(result.stdout, contains('Idiomatically formats Dart source code.'));
+    expect(result.stdout, contains('Format Dart source code.'));
     expect(result.stdout, contains('Usage: dart format [arguments]'));
   });
 
@@ -31,7 +31,7 @@ void format() {
     var result = p.runSync('format', ['--help']);
     expect(result.exitCode, 0);
     expect(result.stderr, isEmpty);
-    expect(result.stdout, contains('Idiomatically formats Dart source code.'));
+    expect(result.stdout, contains('Format Dart source code.'));
     expect(result.stdout, contains('Usage: dart format [arguments]'));
   });
 

pkg/dartdev/test/commands/pub_test.dart

@@ -31,7 +31,7 @@ void pub() {
 
     expect(result.exitCode, 0);
     expect(result.stderr, isEmpty);
-    expect(result.stdout, contains('Pub is a package manager for Dart.'));
+    expect(result.stdout, contains('Work with packages'));
     expect(result.stdout, contains('Usage: dart pub <subcommand> [arguments]'));
     expect(result.stdout,
         contains('Print debugging information when an error occurs.'));

pkg/dartfix/analysis_options.yaml

@@ -23,7 +23,7 @@ linter:
     #
     #- always_declare_return_types # 17
     - always_require_non_null_named_parameters
-    #- annotate_overrides # 4
+    - annotate_overrides
     - avoid_null_checks_in_equality_operators
     - camel_case_extensions
     #- omit_local_variable_types # 44
@@ -36,5 +36,5 @@ linter:
     #- prefer_if_null_operators # 2
     - prefer_single_quotes
     - prefer_spread_collections
-    #- unnecessary_this # 1
+    - unnecessary_this
     - use_function_type_syntax_for_parameters