Fix incorrect retry count check in LazyLLMDataset.__getitem__ #3845
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR type
PR information
Problem
In
LazyLLMDataset.__getitem__
, the loop variablei
is modified inside the retry logic, which can lead to incorrect behavior when checking if the maximum retry attempts (n_try_fetch
) have been reached.For example:
If
i
= 0, it gets reassigned toidx
, but later the conditioni == self.n_try_fetch - 1
may incorrectly evaluate because i is no longer the original loop counter.This could cause the method to either:
Fail too early (if
idx
happens to matchn_try_fetch - 1
).Fail too late (if
i
is reassigned to a smaller value).Solution
Introduce a separate variable n_try to track the actual retry count, ensuring the correct number of attempts is enforced.
This makes the retry logic more robust and predictable.