Merge

Author: modster

.gitignore

@@ -1,10 +1,11 @@
-# Options file with pub/priv keys
-# options.json
-
 # ngrok.exe
 ngrok.exe
 
-# Personal Modules
+# Binance Keys
+.env
 
 # Nodejs Modules
-node_modules
+node_modules
+
+# Personal
+test.js

README.md

@@ -1,7 +1,9 @@
 # 'lil Bot
 ## The littlest crypto bot
 
-Don't you wish you could use TrandingView charts, strategies and indicators to trade REAL crypto? You can! Using TradingView alerts. When an alert is triggered on your chart a webhook contacts this app.js script and tells it to place a buy/sell market order on the binance exchange. 
+Don't you wish you could use TrandingView charts, strategies and indicators to trade REAL crypto? You can! Using TradingView alerts, this repo, and Binance's robust API. 
+
+When an alert is triggered on your chart a webhook contacts this app.js script and tells it to place a buy/sell market order on the binance exchange. 
 
 ## Requirements:
 
@@ -13,7 +15,7 @@ Extract it to a convenient location.
 ### Binance Trading Account
 
 [API key](https://www.binance.com/en/support/articles/360002502072)
-Log in and create a new api key. Beginners should disable withrawls and restrict access to your device's external ip. Copy/paste your info into options.json.
+Log in and create a new api key. Beginners should disable withdrawls. Remember to restrict access to your device's external ip. Copy/paste your info into options.json.
 
 ### NodeJS 
 
@@ -24,8 +26,6 @@ Log in and create a new api key. Beginners should disable withrawls and restrict
 [Download](https://ngrok.com/download)
 Sign up for an account and follow the instructions. Ngrok should be in the same folder as app.js.
 
-**Important:** The ngrok.exe must reside in the same folder as app.js.
-
 ## TradingView Charts 
 
 To use webhooks we need TradingView **Pro** ($10.95/month).
@@ -38,7 +38,7 @@ After the pre-requisits are installed open a terminal in the cloned repository a
 ``` bash
 npm init -y
 
-npm install node-binance-api --save
+npm install
 ```
 
 ## Start:
@@ -49,7 +49,7 @@ To start run the following in your terminal.
 
 ./ngrok http 80
 
-node app.js
+nodemon app.js
 ```
 
 ## Tips
@@ -59,4 +59,4 @@ Ngrok changes your url on startup, so you'll have to copy/paste the new url into
 For testing webhooks go to http://localhost:4040 and select "replay". You can feed your bot any 
 value you want without having to wait for your alerts to be triggered. 
 
-To use the example bollinger ribbon pine script just copy/paste it into the tradingview pine editor at the bottom of your chart. By clicking 'new' a drop down menu displays many default scripts you can easily clone and edit to create your own custom indicators.
+To use the example pine scripts just copy/paste them into the tradingview pine editor at the bottom of your chart. By clicking 'new' a drop down menu displays many default scripts you can easily clone and edit to create your own custom indicators.

app.js

@@ -12,13 +12,22 @@
 const Binance = require( 'node-binance-api' );
 const http = require('http');
 const events = require('events');
-
-
-const binance = new Binance().options('./options.json'); // <---- TODO: tweak recvWindo
-
+require('dotenv').config();
+
+// B i n a n c e - N o d e - A P I   O p t i o n s
+const binance = new Binance().options({
+  APIKEY: process.env.BINANCE_APIKEY,
+  APISECRET: process.env.BINANCE_SECRET,
+  useServerTime: true,
+  recvWindow: 1500, // Set a higher recvWindow to increase response timeout
+  verbose: false, // Add extra output when subscribing to WebSockets, etc
+  test: false,
+  reconnect: true
+  // to do: enable Logging
+});
 
 const symbol = 'BTCUSDT';
-const quantity = 0.015;
+const quantity = 0.0016;
 const hostname = '127.0.0.1';
 const port = 80;
 
@@ -34,53 +43,54 @@ eventEmitter.on('error', (err) => {
 eventEmitter.on('buy', () => {
 
   binance.balance((error, balances) => {
-
-    if (error) {
-      console.error(error);
-      return;
+    if ( error ) return console.error(error);
+    const usdtBal = balances.USDT.available;
+    if (balances.USDT.available > 20.00) {
+      binance.bookTickers('BTCUSDT', (error, ticker) => {
+        tickAsk = ticker.askPrice;
+        let qty = usdtBal/tickAsk;
+        qty = qty.toFixed(5);
+        console.log(tickAsk, usdtBal, qty);
+        binance.marketBuy(symbol, qty);
+      });
+    }
+    else {
+      console.log('Balance < 20.00')
     }
-    
-    if (balances.USDT.available > 15.00) {
-    
-     /*
-      *                  M A R K E T  O R D E R   -   B U Y  
-      */
-      binance.marketBuy(symbol, quantity, (error, response) => {
-        if (error) {
-        console.error(error);
-        }
-        console.log(response)
-        console.log("Bought " + quantity + " Order Id: " + response.orderId);
-      }); // marketBuy 
-    } // if
   }) // binance.balance
 }) // eventemitter.on('buy')
 
-
 eventEmitter.on('sell', () => {
 
   binance.balance((error, balances) => {
-
-    if (error) {
-      console.error(error);
-      return false;
-    }
+    if ( error ) return console.error(error);
 
-    if ( balances.BTC.available > quantity ) {   
-      /*
-      *                  M A R K E T   O R D E R  -  S E L L
-      */
-      binance.marketSell(symbol, quantity, (error, response) => {
-        if (error) {
-          console.error(error); 
-        }
-        console.log(response)
-        console.log('Sold ' + quantity + ' Order Id: ', + response.orderId);
-      }); // marketSell 
-    } // if
+    if ( balances.BTC.available > quantity ) {
+      binance.marketSell(symbol, quantity);
+    }
+  
+    else {
+      
+      binance.marketSell(symbol, balances.BTC.available);
+    }
+    console.log(balances.BTC.available);
   }) // binance.balance
 }) // end eventemitter.on('sell')
 
+//  S T O P
+eventEmitter.on('stop', () => {
+  
+  binance.balance((error, balances) => {
+    if ( error ) return console.error(error);
+
+    if( balances.BTC.available > 0) {
+      btcBalance = parseFloat(balances.BTC.available);
+      console.log(btcBalance);
+      binance.marketSell(symbol, btcBalance);
+    }
+  }) // binance.balance
+  
+}) // end eventemitter.on('stop')
 
 const server = http.createServer((req, res) => {
   //const { headers, method, url } = req;
@@ -99,15 +109,17 @@ const server = http.createServer((req, res) => {
     if(body === 'sell') {
       eventEmitter.emit('sell'); // <---------------------- SELL
     }
-
+    
+    if(body === 'stop') {
+      eventEmitter.emit('stop'); // <---------------------- SELL
+    }
     console.log(body);
     res.statusCode = 200;
     res.end();
     }
   )}
 );
 
-
 server.listen(port, hostname, () => {
   console.log(`Server running at http://${hostname}:${port}/`);
 });