Skip to content

Commit ac0d36f

Browse files
author
Andre Lazari
committed
Fix log of commit exception
1 parent 773fdc1 commit ac0d36f

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/Consumer.php

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ private function executeMessage(\RdKafka\Message $message): void
7676
try {
7777
$this->config->getConsumer()->handle($message->payload);
7878
$success = true;
79-
$this->commit($message, true);
79+
$this->commit($message, $attempts, true);
8080
} catch (\Throwable $exception) {
8181
$this->logger->error($message->offset, $attempts, $exception);
8282

@@ -86,7 +86,7 @@ private function executeMessage(\RdKafka\Message $message): void
8686
} while (!$success);
8787
}
8888

89-
private function commit(\RdKafka\Message $message, bool $success): void
89+
private function commit(\RdKafka\Message $message, int $attempts, bool $success): void
9090
{
9191
try {
9292
if (!$success && !is_null($this->config->getDlq())) {
@@ -103,7 +103,8 @@ private function commit(\RdKafka\Message $message, bool $success): void
103103
return;
104104
}
105105
} catch (\Throwable $throwable) {
106-
$this->logger->error($message, $throwable, 'MESSAGE_COMMIT');
106+
$offset = property_exists($message, 'offset') ? $message->offset : null;
107+
$this->logger->error($offset, $attempts, $throwable);
107108
if ($throwable->getCode() != RD_KAFKA_RESP_ERR__NO_OFFSET) {
108109
throw $throwable;
109110
}
@@ -122,7 +123,7 @@ private function isMaxAttemptReached(\RdKafka\Message $message, int $attempts):
122123
$this->config->getMaxAttempts()->hasMaxAttempts() &&
123124
$this->config->getMaxAttempts()->hasReachedMaxAttempts($attempts)
124125
) {
125-
$this->commit($message, false);
126+
$this->commit($message, $attempts, false);
126127
return true;
127128
}
128129

0 commit comments

Comments
 (0)