-
Notifications
You must be signed in to change notification settings - Fork 85
Support property getter functions #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Because invoking a getter function can potentially change state of the program and this module should not really do that, I don't know what's the right answer. Maybe we render getter functions without their actual values? |
@mohsen1 the perfect way would of course be to to it like chrome. just show them with some different styling and retrieve value on click. but i would be happy even if it did potentially change the state, since getters shouldnt be implemented with bad side-effects anyway. |
I see. Makes sense. I will do it. Per #35 I want to use json-formatter-js internally in this module. I'm moving this to that repo. |
This issue was moved to mohsen1/json-formatter-js#8 |
Any plans to also support property getters (similar to what dev tools in chrome do) or just enumerate them like normal properties
The text was updated successfully, but these errors were encountered: