focus theme loads main.js early causing race condition?

[RogerHaase]

When using focus theme in a window less than 930 pixels wide, and running with the default server on my local repo, there was a 100% failure rate with no error messages when clicking the hamburger link in the UR corner. This happens with both the Firefox and Edge browsers. When using the JS debugger in Firefox, there are no breakpoints triggered in main.js. The local repo was up to date with the moin master repo .

This error could not be reproduced when running with fresh clones of the GitHub moin wiki master nor with my GitHub repo. Dumping the wiki contents from the failing repo and restoring it to a working repo does not cause the error.

But a fix was discovered after cleaning up the loading of main.js.

diff --git a/src/moin/themes/focus/static/js/main.js b/src/moin/themes/focus/static/js/main.js
index d13291de..9041289d 100644
--- a/src/moin/themes/focus/static/js/main.js
+++ b/src/moin/themes/focus/static/js/main.js
@@ -1,4 +1,5 @@
 window.onload = function () {
+    "use strict";
     const headers = []
     const h1 = document.querySelectorAll("#moin-content-data h1")
     const h2 = document.querySelectorAll("#moin-content-data h2")
diff --git a/src/moin/themes/focus/templates/layout.html b/src/moin/themes/focus/templates/layout.html
index 879951b3..c86d435a 100644
--- a/src/moin/themes/focus/templates/layout.html
+++ b/src/moin/themes/focus/templates/layout.html
@@ -13,7 +13,6 @@
 {% set credits = snippets.credits() %}
 
 {% block layout %}
-    <script src="/_themes/focus/js/main.js"></script>
     <div id="moin-main-wrapper">
         {{ before_header }}
         <header id="moin-header" lang="{{ theme_supp.user_lang }}" dir="{{ theme_supp.user_dir }}">
@@ -183,3 +182,8 @@
 
     </div>
 {% endblock %}
+
+{% block body_scripts %}
+    {{ super() }}
+    <script src="/_themes/focus/js/main.js"></script>
+{% endblock %}