Skip to content

Commit b20171b

Browse files
harshithdwivedisamtstern
authored andcommitted
refactor : optimize kotlin snippets in OfflineActivity (firebase#63)
Signed-off-by: the-dagger <[email protected]>
1 parent a788531 commit b20171b

File tree

1 file changed

+11
-11
lines changed
  • database/app/src/main/java/com/google/firebase/referencecode/database/kotlin

1 file changed

+11
-11
lines changed

database/app/src/main/java/com/google/firebase/referencecode/database/kotlin/OfflineActivity.kt

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -33,35 +33,35 @@ class OfflineActivity : AppCompatActivity() {
3333
val scoresRef = FirebaseDatabase.getInstance().getReference("scores")
3434
scoresRef.orderByValue().limitToLast(4).addChildEventListener(object : ChildEventListener {
3535
override fun onChildAdded(snapshot: DataSnapshot, previousChild: String?) {
36-
Log.d(TAG, "The " + snapshot.key + " dinosaur's score is " + snapshot.value)
36+
Log.d(TAG, "The ${snapshot.key} dinosaur's score is ${snapshot.value}")
3737
}
3838

3939
// [START_EXCLUDE]
40-
override fun onChildRemoved(dataSnapshot: DataSnapshot) {}
40+
override fun onChildRemoved(dataSnapshot: DataSnapshot) = Unit
4141

42-
override fun onChildMoved(dataSnapshot: DataSnapshot, s: String?) {}
42+
override fun onChildMoved(dataSnapshot: DataSnapshot, s: String?) = Unit
4343

44-
override fun onCancelled(databaseError: DatabaseError) {}
44+
override fun onCancelled(databaseError: DatabaseError) = Unit
4545

46-
override fun onChildChanged(dataSnapshot: DataSnapshot, s: String?) {}
46+
override fun onChildChanged(dataSnapshot: DataSnapshot, s: String?) = Unit
4747
// [END_EXCLUDE]
4848
})
4949
// [END rtdb_query_recent_scores]
5050

5151
// [START rtdb_query_recent_scores_overlap]
5252
scoresRef.orderByValue().limitToLast(2).addChildEventListener(object : ChildEventListener {
5353
override fun onChildAdded(snapshot: DataSnapshot, previousChild: String?) {
54-
Log.d(TAG, "The " + snapshot.key + " dinosaur's score is " + snapshot.value)
54+
Log.d(TAG, "The ${snapshot.key} dinosaur's score is ${snapshot.value}")
5555
}
5656

5757
// [START_EXCLUDE]
58-
override fun onChildRemoved(dataSnapshot: DataSnapshot) {}
58+
override fun onChildRemoved(dataSnapshot: DataSnapshot) = Unit
5959

60-
override fun onChildMoved(dataSnapshot: DataSnapshot, s: String?) {}
60+
override fun onChildMoved(dataSnapshot: DataSnapshot, s: String?) = Unit
6161

62-
override fun onCancelled(databaseError: DatabaseError) {}
62+
override fun onCancelled(databaseError: DatabaseError) = Unit
6363

64-
override fun onChildChanged(dataSnapshot: DataSnapshot, s: String?) {}
64+
override fun onChildChanged(dataSnapshot: DataSnapshot, s: String?) = Unit
6565
// [END_EXCLUDE]
6666
})
6767
// [END rtdb_query_recent_scores_overlap]
@@ -77,7 +77,7 @@ class OfflineActivity : AppCompatActivity() {
7777
// [START rtdb_on_disconnect_remove]
7878
presenceRef.onDisconnect().removeValue { error, reference ->
7979
error?.let {
80-
Log.d(TAG, "could not establish onDisconnect event:" + error.message)
80+
Log.d(TAG, "could not establish onDisconnect event: ${error.message}")
8181
}
8282
}
8383
// [END rtdb_on_disconnect_remove]

0 commit comments

Comments
 (0)