Merge pull request geotools#439 from n-lagomarsini/GEOT-4677

[GEOT-4677]: added logging and workaround for invalid unit string in time axis

Author: dromagnoli

modules/unsupported/coverage-experiment/unidata/src/main/java/org/geotools/imageio/unidata/UnidataImageReader.java

@@ -384,21 +384,27 @@ private void initMapping(CoordinateSystem cs) {
         // check other dimensions
         for (CoordinateAxis axis : cs.getCoordinateAxes()) {
             // get from coordinate vars
-            final CoordinateVariable<?> cv = coordinatesVariables.get(axis.getFullName()); 
-            final String name = cv.getName();
-            switch(cv.getAxisType()){
-            case GeoX: case GeoY: case Lat: case Lon:
-                continue;
-            case Height: case Pressure: case RadialElevation: case RadialDistance: case GeoZ:
-                if (UnidataCRSUtilities.VERTICAL_AXIS_NAMES.contains(name)) {
-                    dimensionsMapping.put(UnidataUtilities.ELEVATION_DIM, name);
-                } else {
-                    dimensionsMapping.put(name.toUpperCase(), name);
+            final CoordinateVariable<?> cv = coordinatesVariables.get(axis.getFullName());
+            if (cv != null) {
+                final String name = cv.getName();
+                switch(cv.getAxisType()){
+                    case GeoX: case GeoY: case Lat: case Lon:
+                        continue;
+                    case Height: case Pressure: case RadialElevation: case RadialDistance: case GeoZ:
+                        if (UnidataCRSUtilities.VERTICAL_AXIS_NAMES.contains(name)) {
+                            dimensionsMapping.put(UnidataUtilities.ELEVATION_DIM, name);
+                        } else {
+                            dimensionsMapping.put(name.toUpperCase(), name);
+                        }
+                        break;
+                    case Time:
+                        dimensionsMapping.put(UnidataUtilities.TIME_DIM, name);
+                        break;
+                }
+            }else {
+                if (LOGGER.isLoggable(Level.SEVERE)) {
+                    LOGGER.severe("Null coordinate variable: '" + axis.getFullName() + "' while processing input: " + this.getInput());
                 }
-                break;
-            case Time: 
-                dimensionsMapping.put(UnidataUtilities.TIME_DIM, name);
-                break;
             }
         }
     }
@@ -421,11 +427,20 @@ private void extractCoordinatesVariable( ) throws IOException {
             } else {
                 // Workaround for Unsupported Axes
                 Set<String> unsupported = UnidataUtilities.getUnsupportedDimensions();
-                if(axis instanceof CoordinateAxis1D && unsupported.contains(axis.getFullName())){
+                if (axis instanceof CoordinateAxis1D && unsupported.contains(axis.getFullName())) {
                     axis.setAxisType(AxisType.GeoZ);
-                    coordinatesVariables.put(axis.getFullName(), CoordinateVariable.create((CoordinateAxis1D)axis));
-                }else{
-                    LOGGER.warning("Unsupported axis: "+axis + " in input: "+this.getInput() + " has been found");
+                    coordinatesVariables.put(axis.getFullName(),
+                            CoordinateVariable.create((CoordinateAxis1D) axis));
+                // Workaround for files that have a time dimension, but in a format that could not be parsed
+                } else if ("time".equals(axis.getFullName())) {
+                    LOGGER.warning("Detected unparseable unit string in time axis: '"
+                            + axis.getUnitsString() + "'.");
+                    axis.setAxisType(AxisType.Time);
+                    coordinatesVariables.put(axis.getFullName(),
+                            CoordinateVariable.create((CoordinateAxis1D) axis));
+                } else {
+                    LOGGER.warning("Unsupported axis: " + axis + " in input: " + this.getInput()
+                            + " has been found");
                 }
             }
         }