Skip to content

Commit b86bb22

Browse files
committed
Rename sortDir to order
1 parent cc248a5 commit b86bb22

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

src/create-routes.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,12 @@ module.exports = function(object, filename) {
3939
var _start = req.query._start
4040
var _end = req.query._end
4141
var _sort = req.query._sort
42-
var _sortDir = req.query._sortDir
42+
var _order = req.query._order
4343

4444
delete req.query._start
4545
delete req.query._end
4646
delete req.query._sort
47-
delete req.query._sortDir
47+
delete req.query._order
4848

4949
if (req.query.q) {
5050

@@ -84,13 +84,13 @@ module.exports = function(object, filename) {
8484
}
8585

8686
if(_sort) {
87-
_sortDir = _sortDir || 'ASC'
87+
_order = _order || 'ASC'
8888

8989
array = _.sortBy(array, function(element) {
9090
return element[_sort];
9191
})
9292

93-
if (_sortDir === 'DESC') {
93+
if (_order === 'DESC') {
9494
array.reverse();
9595
}
9696
}

test/index.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,17 +104,17 @@ describe('Server', function() {
104104
.expect(200, done)
105105
})
106106

107-
it('should reverse sorting with sortDir=DESC', function(done) {
107+
it('should reverse sorting with order=DESC', function(done) {
108108
request(server)
109-
.get('/tags?_sort=body&_sortDir=DESC')
109+
.get('/tags?_sort=body&_order=DESC')
110110
.expect('Content-Type', /json/)
111111
.expect([db.tags[2], db.tags[0], db.tags[1]])
112112
.expect(200, done)
113113
})
114114

115115
it('should sort on numerical field', function(done) {
116116
request(server)
117-
.get('/posts?_sort=id&_sortDir=DESC')
117+
.get('/posts?_sort=id&_order=DESC')
118118
.expect('Content-Type', /json/)
119119
.expect(db.posts.reverse())
120120
.expect(200, done)

0 commit comments

Comments
 (0)