Skip to content

Commit d820d6c

Browse files
authored
ensure google_sql_database_instance's database_version attribute is string (bridgecrewio#2377)
1 parent 8d2423e commit d820d6c

10 files changed

+10
-10
lines changed

checkov/terraform/checks/resource/gcp/GoogleCloudMySqlLocalInfileOff.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ def scan_resource_conf(self, conf):
1818
configuration
1919
:return: < CheckResult >
2020
"""
21-
if 'database_version' in conf.keys() and 'MYSQL' in conf['database_version'][0]:
21+
if 'database_version' in conf.keys() and isinstance(conf['database_version'][0], str) and 'MYSQL' in conf['database_version'][0]:
2222
if 'settings' in conf.keys():
2323
self.evaluated_keys = ['database_version/[0]/MYSQL', 'settings']
2424
flags = conf['settings'][0].get('database_flags')

checkov/terraform/checks/resource/gcp/GoogleCloudPostgreSqlLogCheckpoints.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ def scan_resource_conf(self, conf):
1818
configuration
1919
:return: < CheckResult >
2020
"""
21-
if 'database_version' in conf.keys() and 'POSTGRES' in conf['database_version'][0]:
21+
if 'database_version' in conf.keys() and isinstance(conf['database_version'][0], str) and 'POSTGRES' in conf['database_version'][0]:
2222
if 'settings' in conf.keys():
2323
self.evaluated_keys = ['database_version/[0]/POSTGRES', 'settings']
2424
flags = conf['settings'][0].get('database_flags')

checkov/terraform/checks/resource/gcp/GoogleCloudPostgreSqlLogConnection.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ def scan_resource_conf(self, conf):
1818
configuration
1919
:return: < CheckResult >
2020
"""
21-
if 'database_version' in conf.keys() and 'POSTGRES' in conf['database_version'][0]:
21+
if 'database_version' in conf.keys() and isinstance(conf['database_version'][0], str) and 'POSTGRES' in conf['database_version'][0]:
2222
if 'settings' in conf.keys():
2323
self.evaluated_keys = ['database_version/[0]/POSTGRES', 'settings']
2424
flags = conf['settings'][0].get('database_flags')

checkov/terraform/checks/resource/gcp/GoogleCloudPostgreSqlLogDisconnection.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ def scan_resource_conf(self, conf):
1818
configuration
1919
:return: < CheckResult >
2020
"""
21-
if 'database_version' in conf.keys() and 'POSTGRES' in conf['database_version'][0]:
21+
if 'database_version' in conf.keys() and isinstance(conf['database_version'][0], str) and 'POSTGRES' in conf['database_version'][0]:
2222
if 'settings' in conf.keys():
2323
self.evaluated_keys = ['database_version/[0]/POSTGRES', 'settings']
2424
flags = conf['settings'][0].get('database_flags')

checkov/terraform/checks/resource/gcp/GoogleCloudPostgreSqlLogLockWaits.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ def scan_resource_conf(self, conf):
1818
configuration
1919
:return: < CheckResult >
2020
"""
21-
if 'database_version' in conf.keys() and 'POSTGRES' in conf['database_version'][0]:
21+
if 'database_version' in conf.keys() and isinstance(conf['database_version'][0], str) and 'POSTGRES' in conf['database_version'][0]:
2222
if 'settings' in conf.keys():
2323
self.evaluated_keys = ['database_version/[0]/POSTGRES', 'settings']
2424
flags = conf['settings'][0].get('database_flags')

checkov/terraform/checks/resource/gcp/GoogleCloudPostgreSqlLogMinDuration.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ def scan_resource_conf(self, conf):
1919
configuration
2020
:return: < CheckResult >
2121
"""
22-
if 'database_version' in conf.keys() and 'POSTGRES' in conf['database_version'][0]:
22+
if 'database_version' in conf.keys() and isinstance(conf['database_version'][0], str) and 'POSTGRES' in conf['database_version'][0]:
2323
if 'settings' in conf.keys():
2424
self.evaluated_keys = ['database_version/[0]/POSTGRES', 'settings']
2525
flags = conf['settings'][0].get('database_flags')

checkov/terraform/checks/resource/gcp/GoogleCloudPostgreSqlLogMinMessage.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ def scan_resource_conf(self, conf):
1818
configuration
1919
:return: < CheckResult >
2020
"""
21-
if 'database_version' in conf.keys() and 'POSTGRES' in conf['database_version'][0]:
21+
if 'database_version' in conf.keys() and isinstance(conf['database_version'][0], str) and 'POSTGRES' in conf['database_version'][0]:
2222
if 'settings' in conf.keys():
2323
self.evaluated_keys = ['database_version/[0]/POSTGRES', 'settings']
2424
flags = conf['settings'][0].get('database_flags')

checkov/terraform/checks/resource/gcp/GoogleCloudPostgreSqlLogTemp.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ def scan_resource_conf(self, conf):
1818
configuration
1919
:return: < CheckResult >
2020
"""
21-
if 'database_version' in conf.keys() and 'POSTGRES' in conf['database_version'][0]:
21+
if 'database_version' in conf.keys() and isinstance(conf['database_version'][0], str) and 'POSTGRES' in conf['database_version'][0]:
2222
if 'settings' in conf.keys():
2323
self.evaluated_keys = ['database_version/[0]/POSTGRES', 'settings']
2424
flags = conf['settings'][0].get('database_flags')

checkov/terraform/checks/resource/gcp/GoogleCloudSqlServerContainedDBAuthentication.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ def scan_resource_conf(self, conf):
1818
configuration
1919
:return: < CheckResult >
2020
"""
21-
if 'database_version' in conf.keys() and 'SQLSERVER' in conf['database_version'][0]:
21+
if 'database_version' in conf.keys() and isinstance(conf['database_version'][0], str) and 'SQLSERVER' in conf['database_version'][0]:
2222
if 'settings' in conf.keys():
2323
self.evaluated_keys = ['database_version/[0]/SQLSERVER', 'settings']
2424
flags = conf['settings'][0].get('database_flags')

checkov/terraform/checks/resource/gcp/GoogleCloudSqlServerCrossDBOwnershipChaining.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ def scan_resource_conf(self, conf):
1818
configuration
1919
:return: < CheckResult >
2020
"""
21-
if 'database_version' in conf.keys() and 'SQLSERVER' in conf['database_version'][0]:
21+
if 'database_version' in conf.keys() and isinstance(conf['database_version'][0], str) and 'SQLSERVER' in conf['database_version'][0]:
2222
if 'settings' in conf.keys():
2323
self.evaluated_keys = ['database_version/[0]/SQLSERVER', 'settings']
2424
flags = conf['settings'][0].get('database_flags')

0 commit comments

Comments
 (0)