Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: iCamilo/ios-lead-essentials-feed-api-challenge
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: mulp/ios-lead-essentials-feed-api-challenge
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 9 commits
  • 5 files changed
  • 1 contributor

Commits on Aug 31, 2020

  1. Silence XCode12 warnings

    @mulp
    mulp committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    32e2c88 View commit details
    Browse the repository at this point in the history

  2. Delivers request data from URL twice by calling the get method from t… 

    …he feed loader load method
    @mulp
    mulp committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    284daa9 View commit details
    Browse the repository at this point in the history

  3. Delivers connectivity error on client error

    @mulp
    mulp committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    e3eea42 View commit details
    Browse the repository at this point in the history

  4. Delivers invalid data error on non 200 HTTP response

    @mulp
    mulp committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    5ba3086 View commit details
    Browse the repository at this point in the history

  5. Delivers invalid data error on 200 HTTP response code with invalid JSON

    @mulp
    mulp committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    9c9e67a View commit details
    Browse the repository at this point in the history

  6. Delivers success with no items on 200 HTTP response with empty JSON list

    @mulp
    mulp committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    a2b349f View commit details
    Browse the repository at this point in the history

  7. Move response status check to the mapper so simplify logic and increa… 

    …se readability
    @mulp
    mulp committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    b3dfe55 View commit details
    Browse the repository at this point in the history

  8. Delivers success with items on 200 HTTP response with JSON items

    @mulp
    mulp committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    7e4b897 View commit details
    Browse the repository at this point in the history

  9. Check if self is nil before to process the result. It it's nil return

    @mulp
    mulp committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    95e0b3e View commit details
    Browse the repository at this point in the history
Loading