Skip to content

Commit b22a232

Browse files
davidblncthymikee
authored andcommitted
[Docs] Fixed bug in example code (jestjs#6828)
# Summary Fixed bug in example code: mutated the previous state without the use of a callback in _setState_
1 parent 9093a3c commit b22a232

File tree

7 files changed

+7
-9
lines changed

7 files changed

+7
-9
lines changed

CHANGELOG.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,8 @@
2828
### Chore & Maintenance
2929

3030
- `[docs]` Document another option to avoid warnings with React 16 ([#5258](https://github.com/facebook/jest/issues/5258))
31-
32-
### Chore & Maintenance
33-
3431
- `[docs]` Add note explaining when `jest.setTimeout` should be called ([#6817](https://github.com/facebook/jest/pull/6817/files))
32+
- `[docs]` Fixed bug in example code ([#6828](https://github.com/facebook/jest/pull/6828))
3533

3634
## 23.4.2
3735

website/versioned_docs/version-22.0/TutorialReact.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ export default class CheckboxWithLabel extends React.Component {
191191
}
192192

193193
onChange() {
194-
this.setState({isChecked: !this.state.isChecked});
194+
this.setState(prevState => ({isChecked: !prevState.isChecked}));
195195
}
196196

197197
render() {

website/versioned_docs/version-22.1/TutorialReact.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ export default class CheckboxWithLabel extends React.Component {
220220
}
221221

222222
onChange() {
223-
this.setState({isChecked: !this.state.isChecked});
223+
this.setState(prevState => ({isChecked: !prevState.isChecked}));
224224
}
225225

226226
render() {

website/versioned_docs/version-22.2/TutorialReact.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ export default class CheckboxWithLabel extends React.Component {
220220
}
221221

222222
onChange() {
223-
this.setState({isChecked: !this.state.isChecked});
223+
this.setState(prevState => ({isChecked: !prevState.isChecked}));
224224
}
225225

226226
render() {

website/versioned_docs/version-22.3/TutorialReact.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ export default class CheckboxWithLabel extends React.Component {
220220
}
221221

222222
onChange() {
223-
this.setState({isChecked: !this.state.isChecked});
223+
this.setState(prevState => ({isChecked: !prevState.isChecked}));
224224
}
225225

226226
render() {

website/versioned_docs/version-22.4/TutorialReact.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ export default class CheckboxWithLabel extends React.Component {
220220
}
221221

222222
onChange() {
223-
this.setState({isChecked: !this.state.isChecked});
223+
this.setState(prevState => ({isChecked: !prevState.isChecked}));
224224
}
225225

226226
render() {

website/versioned_docs/version-23.0/TutorialReact.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ export default class CheckboxWithLabel extends React.Component {
226226
}
227227

228228
onChange() {
229-
this.setState({isChecked: !this.state.isChecked});
229+
this.setState(prevState => ({isChecked: !prevState.isChecked}));
230230
}
231231

232232
render() {

0 commit comments

Comments
 (0)