drop Eq impl, use arg_types to compare types.

Author: Anciety

src/command.rs

@@ -27,31 +27,6 @@ pub struct Command<'a> {
     pub handler: Box<Handler<'a>>,
 }
 
-/// Command equals when types equal
-impl<'a> std::cmp::PartialEq for Command<'a> {
-    fn eq(&self, other: &Self) -> bool {
-        if self.args_info.len() != other.args_info.len() {
-            return false;
-        }
-
-        for i in 0..self.args_info.len() {
-            let my_arg = &self.args_info[i];
-            let other_arg = &other.args_info[i];
-
-            let my_type_str = my_arg.split(":").collect::<Vec<_>>()[1];
-            let other_type_str = other_arg.split(":").collect::<Vec<_>>()[1];
-
-            if my_type_str != other_type_str {
-                return false;
-            }
-        }
-
-        true
-    }
-}
-
-impl<'a> std::cmp::Eq for Command<'a> {}
-
 /// Return status of a command.
 #[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]
 pub enum CommandStatus {
@@ -121,6 +96,14 @@ impl<'a> Command<'a> {
     pub fn run(&mut self, args: &[&str]) -> anyhow::Result<CommandStatus> {
         (self.handler)(args)
     }
+
+    /// Returns the string description of the argument types
+    pub fn arg_types(&self) -> Vec<&str> {
+        self.args_info
+            .iter()
+            .map(|info| info.split(":").collect::<Vec<_>>()[1])
+            .collect()
+    }
 }
 
 impl<'a> std::fmt::Debug for Command<'a> {

src/repl.rs

@@ -183,7 +183,7 @@ impl<'a> ReplBuilder<'a> {
                 return Err(BuilderError::InvalidName(name));
             } else if RESERVED.iter().any(|(n, _)| *n == name) {
                 return Err(BuilderError::ReservedName(name));
-            } else if cmds.iter().any(|c| *c == cmd) {
+            } else if cmds.iter().any(|c| c.arg_types() == cmd.arg_types()) {
                 return Err(BuilderError::DuplicateCommands(name));
             }
             cmds.push(cmd);
@@ -325,7 +325,7 @@ Other commands:
                         let cmds = self.commands.get_mut(name).unwrap();
                         writeln!(&mut self.out, "Usage:")?;
                         for cmd in cmds.iter() {
-                            writeln!(&mut self.out, "{} {}", name, cmd.args_info.join(" "))?;
+                            writeln!(&mut self.out, "  {} {}", name, cmd.args_info.join(" "))?;
                         }
                     }
                     Ok(LoopStatus::Continue)