Variables for resources to satify security requirements

Author: topfunky

main.tf

@@ -10,6 +10,10 @@ variable "secret_key" {
   description = "The AWS secret key used to provision resources"
 }
 
+variable "security_group_id" {
+  description = "The security group with ingress and egress rules that EC2 instances will be created within."
+}
+
 variable "region" {
   description = "The AWS region in which to provision resources"
   default     = "us-west-2"
@@ -19,6 +23,10 @@ variable "identity" {
   description = "A unique name for your resources"
 }
 
+variable "ami" {
+  description = "The Amazon Machine Image for new instances."
+}
+
 variable "num_webs" {
   description = "The number of servers to run"
   default     = "1"
@@ -34,8 +42,10 @@ provider "aws" {
 module "server" {
   source = "./server"
 
-  num_webs = "${var.num_webs}"
-  identity = "${var.identity}"
+  num_webs          = "${var.num_webs}"
+  identity          = "${var.identity}"
+  security_group_id = "${var.security_group_id}"
+  ami               = "${var.ami}"
 }
 
 output "public_ip" {

server/main.tf

@@ -12,46 +12,16 @@ variable "identity" {
   description = "A unique name for this server"
 }
 
-resource "aws_security_group" "web" {
-  name = "${var.identity}-sg"
-
-  ingress {
-    from_port   = 80
-    to_port     = 80
-    protocol    = "tcp"
-    cidr_blocks = ["0.0.0.0/0"]
-  }
-
-  ingress {
-    from_port   = "22"
-    to_port     = "22"
-    protocol    = "TCP"
-    cidr_blocks = ["0.0.0.0/0"]
-  }
-
-  egress {
-    from_port   = 0
-    to_port     = 0
-    protocol    = "-1"
-    cidr_blocks = ["0.0.0.0/0"]
-  }
-
-  tags {
-    "Identity"   = "${var.identity}"
-    "Created-by" = "Terraform"
-  }
-
-  lifecycle {
-    create_before_destroy = true
-  }
+variable "security_group_id" {
+  description = "The AWS security group with ingress and egress rules for this instance."
 }
 
 resource "aws_instance" "web" {
   ami           = "${var.ami}"
   instance_type = "t2.medium"
   count         = "${var.num_webs}"
 
-  vpc_security_group_ids = ["${aws_security_group.web.id}"]
+  vpc_security_group_ids = ["${var.security_group_id}"]
 
   tags {
     "Name"       = "${var.identity} web ${count.index+1}/${var.num_webs}"