Skip to content

Commit 555b39e

Browse files
author
TSUNG-WEI HUANG
committed
updated -Wshadow
1 parent 12646d7 commit 555b39e

32 files changed

+404
-668
lines changed

CMakeLists.txt

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -168,9 +168,9 @@ add_library(tf::error_settings ALIAS error_settings)
168168
target_compile_options(
169169
error_settings
170170
INTERFACE
171-
$<$<CXX_COMPILER_ID:AppleClang>:-Wall -Wextra -Wfatal-errors>
172-
$<$<AND:$<COMPILE_LANGUAGE:CXX>,$<CXX_COMPILER_ID:Clang>>:-Wall -Wextra -Wfatal-errors>
173-
$<$<AND:$<COMPILE_LANGUAGE:CXX>,$<CXX_COMPILER_ID:GNU>>:-Wall -Wextra -Wfatal-errors>
171+
$<$<CXX_COMPILER_ID:AppleClang>:-Wall -Wextra -Wfatal-errors -Wshadow>
172+
$<$<AND:$<COMPILE_LANGUAGE:CXX>,$<CXX_COMPILER_ID:Clang>>:-Wall -Wextra -Wfatal-errors -Wshadow>
173+
$<$<AND:$<COMPILE_LANGUAGE:CXX>,$<CXX_COMPILER_ID:GNU>>:-Wall -Wextra -Wfatal-errors -Wshadow>
174174
$<$<AND:$<COMPILE_LANGUAGE:CXX>,$<CXX_COMPILER_ID:MSVC>>:/W3 /permissive->
175175
)
176176

@@ -181,7 +181,7 @@ if(TF_BUILD_CUDA)
181181
error_settings
182182
BEFORE
183183
INTERFACE
184-
$<$<COMPILE_LANGUAGE:CUDA>:--extended-lambda -Xcompiler=-Wall,-Wextra,-Wfatal-errors>
184+
$<$<COMPILE_LANGUAGE:CUDA>:--extended-lambda -Xcompiler=-Wall,-Wextra,-Wfatal-errors,-Wshadow>
185185
)
186186
endif(TF_BUILD_CUDA)
187187

@@ -252,6 +252,7 @@ message(STATUS "CMAKE_CXX_COMPILER: " ${CMAKE_CXX_COMPILER})
252252
message(STATUS "CMAKE_CXX_COMPILER_ID: " ${CMAKE_CXX_COMPILER_ID})
253253
message(STATUS "CMAKE_CXX_COMPILER_VERSION: " ${CMAKE_CXX_COMPILER_VERSION})
254254
message(STATUS "CMAKE_CXX_FLAGS: " ${CMAKE_CXX_FLAGS})
255+
message(STATUS "CMAKE_CXX_STANDARD: " ${CMAKE_CXX_STANDARD})
255256
message(STATUS "CMAKE_CUDA_COMPILER: " ${CMAKE_CUDA_COMPILER})
256257
message(STATUS "CMAKE_CUDA_COMPILER_ID: " ${CMAKE_CUDA_COMPILER_ID})
257258
message(STATUS "CMAKE_CUDA_COMPILER_VERSION: " ${CMAKE_CUDA_COMPILER_VERSION})

docs/release-3-7-0.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,15 +68,15 @@ <h3>Contents</h3>
6868
<li><a href="#release-3-7-0_miscellaneous_items">Miscellaneous Items</a></li>
6969
</ul>
7070
</nav>
71-
<p>Taskflow 3.7.0 is the newest developing line to new features and improvements we continue to support. It is also where this documentation is generated. Many things are considered <em>experimental</em> and may change or break from time to time. While it may be difficult to be keep all things consistent when introducing new features, we continue to try our best to ensure backward compatibility.</p><section id="release-3-7-0_download"><h2><a href="#release-3-7-0_download">Download</a></h2><p>To download the newest version of Taskflow, please clone the master branch from <a href="https://github.com/taskflow/taskflow">Taskflow&#x27;s GitHub</a>.</p></section><section id="release-3-7-0_system_requirements"><h2><a href="#release-3-7-0_system_requirements">System Requirements</a></h2><p>To use Taskflow v3.7.0, you need a compiler that supports C++17:</p><ul><li>GNU C++ Compiler at least v8.4 with -std=c++17</li><li>Clang C++ Compiler at least v6.0 with -std=c++17</li><li>Microsoft Visual Studio at least v19.27 with /std:c++17</li><li>AppleClang Xcode Version at least v12.0 with -std=c++17</li><li>Nvidia CUDA Toolkit and Compiler (nvcc) at least v11.1 with -std=c++17</li><li>Intel C++ Compiler at least v19.0.1 with -std=c++17</li><li>Intel DPC++ Clang Compiler at least v13.0.0 with -std=c++17 and SYCL20</li></ul><p>Taskflow works on Linux, Windows, and Mac OS X.</p></section><section id="release-3-7-0_summary"><h2><a href="#release-3-7-0_summary">Release Summary</a></h2></section><section id="release-3-7-0_new_features"><h2><a href="#release-3-7-0_new_features">New Features</a></h2><section id="release-3-7-0_taskflow_core"><h3><a href="#release-3-7-0_taskflow_core">Taskflow Core</a></h3><ul><li>Improved scheduling performance of dependent asynchronous tasks</li><li>Improved scheduling performance of module task by removing busy looping</li><li>Improved <a href="classtf_1_1Executor.html#ab9aa252f70e9a40020a1e5a89d485b85" class="m-doc">tf::<wbr />Executor::<wbr />wait_for_all</a> using C++20 atomic wait</li><li>Improved tf::Notifier using C++20 atomic wait</li><li>Improved worker-thread ID mapping performance using C++20 atomic wait</li><li>Added <a href="classtf_1_1AsyncTask.html#aefeefa30d7cafdfbb7dc8def542e8e51" class="m-doc">tf::<wbr />AsyncTask::<wbr />is_done</a> to query the completion status of an async task</li><li>Added <a href="classtf_1_1Taskflow.html#a354a7673fabeaf3be66928ad6b573900" class="m-doc">tf::<wbr />Taskflow::<wbr />remove_dependency</a> to remove dependencies from the graph</li><li>Added support for exception in <a href="classtf_1_1Taskflow.html" class="m-doc">tf::<wbr />Taskflow</a> and <a href="classtf_1_1Executor.html" class="m-doc">tf::<wbr />Executor</a></li></ul><pre class="m-code"><span class="n">tf</span><span class="o">::</span><span class="n">Executor</span><span class="w"> </span><span class="n">executor</span><span class="p">;</span><span class="w"></span>
71+
<p>Taskflow 3.7.0 is the newest developing line to new features and improvements we continue to support. It is also where this documentation is generated. Many things are considered <em>experimental</em> and may change or break from time to time. While it may be difficult to be keep all things consistent when introducing new features, we continue to try our best to ensure backward compatibility.</p><section id="release-3-7-0_download"><h2><a href="#release-3-7-0_download">Download</a></h2><p>To download the newest version of Taskflow, please clone the master branch from <a href="https://github.com/taskflow/taskflow">Taskflow&#x27;s GitHub</a>.</p></section><section id="release-3-7-0_system_requirements"><h2><a href="#release-3-7-0_system_requirements">System Requirements</a></h2><p>To use Taskflow v3.7.0, you need a compiler that supports C++17:</p><ul><li>GNU C++ Compiler at least v8.4 with -std=c++17</li><li>Clang C++ Compiler at least v6.0 with -std=c++17</li><li>Microsoft Visual Studio at least v19.27 with /std:c++17</li><li>AppleClang Xcode Version at least v12.0 with -std=c++17</li><li>Nvidia CUDA Toolkit and Compiler (nvcc) at least v11.1 with -std=c++17</li><li>Intel C++ Compiler at least v19.0.1 with -std=c++17</li><li>Intel DPC++ Clang Compiler at least v13.0.0 with -std=c++17 and SYCL20</li></ul><p>Taskflow works on Linux, Windows, and Mac OS X.</p></section><section id="release-3-7-0_summary"><h2><a href="#release-3-7-0_summary">Release Summary</a></h2></section><section id="release-3-7-0_new_features"><h2><a href="#release-3-7-0_new_features">New Features</a></h2><section id="release-3-7-0_taskflow_core"><h3><a href="#release-3-7-0_taskflow_core">Taskflow Core</a></h3><ul><li>Improved scheduling performance of dependent asynchronous tasks</li><li>Improved scheduling performance of module task by removing busy looping</li><li>Improved <a href="classtf_1_1Executor.html#ab9aa252f70e9a40020a1e5a89d485b85" class="m-doc">tf::<wbr />Executor::<wbr />wait_for_all</a> using C++20 atomic wait</li><li>Improved tf::Notifier using C++20 atomic wait</li><li>Improved worker-thread ID mapping performance using C++20 atomic wait</li><li>Added <code>-Wshadow</code> to the compilation check</li><li>Added <a href="classtf_1_1AsyncTask.html#aefeefa30d7cafdfbb7dc8def542e8e51" class="m-doc">tf::<wbr />AsyncTask::<wbr />is_done</a> to query the completion status of an async task</li><li>Added <a href="classtf_1_1Taskflow.html#a354a7673fabeaf3be66928ad6b573900" class="m-doc">tf::<wbr />Taskflow::<wbr />remove_dependency</a> to remove dependencies from the graph</li><li>Added support for exception in <a href="classtf_1_1Taskflow.html" class="m-doc">tf::<wbr />Taskflow</a> and <a href="classtf_1_1Executor.html" class="m-doc">tf::<wbr />Executor</a></li></ul><pre class="m-code"><span class="n">tf</span><span class="o">::</span><span class="n">Executor</span><span class="w"> </span><span class="n">executor</span><span class="p">;</span><span class="w"></span>
7272
<span class="n">tf</span><span class="o">::</span><span class="n">Taskflow</span><span class="w"> </span><span class="n">taskflow</span><span class="p">;</span><span class="w"></span>
7373
<span class="n">taskflow</span><span class="p">.</span><span class="n">emplace</span><span class="p">([](){</span><span class="w"> </span><span class="k">throw</span><span class="w"> </span><span class="n">std</span><span class="o">::</span><span class="n">runtime_error</span><span class="p">(</span><span class="s">&quot;exception&quot;</span><span class="p">);</span><span class="w"> </span><span class="p">});</span><span class="w"></span>
7474
<span class="k">try</span><span class="w"> </span><span class="p">{</span><span class="w"></span>
7575
<span class="w"> </span><span class="n">executor</span><span class="p">.</span><span class="n">run</span><span class="p">(</span><span class="n">taskflow</span><span class="p">).</span><span class="n">get</span><span class="p">();</span><span class="w"></span>
7676
<span class="p">}</span><span class="w"></span>
7777
<span class="k">catch</span><span class="p">(</span><span class="k">const</span><span class="w"> </span><span class="n">std</span><span class="o">::</span><span class="n">runtime_error</span><span class="o">&amp;</span><span class="w"> </span><span class="n">e</span><span class="p">)</span><span class="w"> </span><span class="p">{</span><span class="w"></span>
7878
<span class="w"> </span><span class="n">std</span><span class="o">::</span><span class="n">cerr</span><span class="w"> </span><span class="o">&lt;&lt;</span><span class="w"> </span><span class="n">e</span><span class="p">.</span><span class="n">what</span><span class="p">()</span><span class="w"> </span><span class="o">&lt;&lt;</span><span class="w"> </span><span class="n">std</span><span class="o">::</span><span class="n">endl</span><span class="p">;</span><span class="w"></span>
79-
<span class="p">}</span><span class="w"></span></pre><ul><li>Modified the CI to exclude exception test under sanitizers</li></ul></section><section id="release-3-7-0_utilities"><h3><a href="#release-3-7-0_utilities">Utilities</a></h3></section></section><section id="release-3-7-0_bug_fixes"><h2><a href="#release-3-7-0_bug_fixes">Bug Fixes</a></h2><ul><li>Fixed compilation erros of CUDA examples caused by not including <code><a href="for__each_8hpp.html" class="m-doc">for_<wbr />each.hpp</a></code></li></ul></section><section id="release-3-7-0_breaking_changes"><h2><a href="#release-3-7-0_breaking_changes">Breaking Changes</a></h2><ul><li>Renamed tf::Runtime::join to <a href="classtf_1_1Runtime.html#afcc18484a95fd2a834940d878eaf4dfc" class="m-doc">tf::<wbr />Runtime::<wbr />corun_all</a></li><li>Removed tf::WorkerInterface due to the support of exception</li></ul></section><section id="release-3-7-0_documentation"><h2><a href="#release-3-7-0_documentation">Documentation</a></h2><ul><li>Revised <a href="DependentAsyncTasking.html" class="m-doc">Asynchronous Tasking with Dependencies</a><ul><li>Added <a href="DependentAsyncTasking.html#QueryTheComppletionStatusOfDependentAsyncTasks" class="m-doc">Query the Completion Status of Dependent Async Tasks</a></li></ul></li><li>Revised <a href="ExceptionHandling.html" class="m-doc">Exception Handling</a></li><li>Revised <a href="ExecuteTaskflow.html" class="m-doc">Executor</a><ul><li>Removed the section of tf::WorkerInterface</li></ul></li></ul></section><section id="release-3-7-0_miscellaneous_items"><h2><a href="#release-3-7-0_miscellaneous_items">Miscellaneous Items</a></h2><p>Please do not hesitate to contact <a href="https://tsung-wei-huang.github.io/">Dr. Tsung-Wei Huang</a> if you intend to collaborate with us on using Taskflow in your scientific computing projects.</p></section>
79+
<span class="p">}</span><span class="w"></span></pre><ul><li>Modified the CI to exclude exception test under sanitizers</li></ul></section><section id="release-3-7-0_utilities"><h3><a href="#release-3-7-0_utilities">Utilities</a></h3></section></section><section id="release-3-7-0_bug_fixes"><h2><a href="#release-3-7-0_bug_fixes">Bug Fixes</a></h2><ul><li>Fixed compilation erros of CUDA examples caused by not including <code><a href="for__each_8hpp.html" class="m-doc">for_<wbr />each.hpp</a></code></li><li>Fixed the runtime error of <a href="classtf_1_1FlowBuilder.html#a47ea2b35d0ec18afb35b45316939dc67" class="m-doc">tf::<wbr />Taskflow::<wbr />for_each_index</a> when the range invalid</li></ul></section><section id="release-3-7-0_breaking_changes"><h2><a href="#release-3-7-0_breaking_changes">Breaking Changes</a></h2><ul><li>Renamed tf::Runtime::join to <a href="classtf_1_1Runtime.html#afcc18484a95fd2a834940d878eaf4dfc" class="m-doc">tf::<wbr />Runtime::<wbr />corun_all</a></li><li>Removed tf::WorkerInterface due to the support of exception</li></ul></section><section id="release-3-7-0_documentation"><h2><a href="#release-3-7-0_documentation">Documentation</a></h2><ul><li>Revised <a href="DependentAsyncTasking.html" class="m-doc">Asynchronous Tasking with Dependencies</a><ul><li>Added <a href="DependentAsyncTasking.html#QueryTheComppletionStatusOfDependentAsyncTasks" class="m-doc">Query the Completion Status of Dependent Async Tasks</a></li></ul></li><li>Revised <a href="ExceptionHandling.html" class="m-doc">Exception Handling</a></li><li>Revised <a href="ExecuteTaskflow.html" class="m-doc">Executor</a><ul><li>Removed the section of tf::WorkerInterface</li></ul></li></ul></section><section id="release-3-7-0_miscellaneous_items"><h2><a href="#release-3-7-0_miscellaneous_items">Miscellaneous Items</a></h2><p>Please do not hesitate to contact <a href="https://tsung-wei-huang.github.io/">Dr. Tsung-Wei Huang</a> if you intend to collaborate with us on using Taskflow in your scientific computing projects.</p></section>
8080
</div>
8181
</div>
8282
</div>

0 commit comments

Comments
 (0)