Skip to content

Commit e73bc83

Browse files
authored
Merge pull request piotrplenik#166 from peter-gribanov/js_to_php
Rename function parseBetterJSAlternative()
2 parents c3ba178 + f9d66a2 commit e73bc83

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -629,7 +629,7 @@ testing.
629629
**Bad:**
630630

631631
```php
632-
function parseBetterJSAlternative(string $code): void
632+
function parseBetterPHPAlternative(string $code): void
633633
{
634634
$regexes = [
635635
// ...
@@ -656,7 +656,7 @@ function parseBetterJSAlternative(string $code): void
656656

657657
**Bad too:**
658658

659-
We have carried out some of the functionality, but the `parseBetterJSAlternative()` function is still very complex and not testable.
659+
We have carried out some of the functionality, but the `parseBetterPHPAlternative()` function is still very complex and not testable.
660660

661661
```php
662662
function tokenize(string $code): array
@@ -686,7 +686,7 @@ function lexer(array $tokens): array
686686
return $ast;
687687
}
688688

689-
function parseBetterJSAlternative(string $code): void
689+
function parseBetterPHPAlternative(string $code): void
690690
{
691691
$tokens = tokenize($code);
692692
$ast = lexer($tokens);
@@ -698,7 +698,7 @@ function parseBetterJSAlternative(string $code): void
698698

699699
**Good:**
700700

701-
The best solution is move out the dependencies of `parseBetterJSAlternative()` function.
701+
The best solution is move out the dependencies of `parseBetterPHPAlternative()` function.
702702

703703
```php
704704
class Tokenizer
@@ -734,7 +734,7 @@ class Lexer
734734
}
735735
}
736736

737-
class BetterJSAlternative
737+
class BetterPHPAlternative
738738
{
739739
private $tokenizer;
740740
private $lexer;

0 commit comments

Comments
 (0)