Skip to content

Add an input below the "Play as Browser Guide" button to configure the connection URL (to the database) #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ggrossetie opened this issue Oct 28, 2021 · 3 comments · Fixed by #80

Comments

@ggrossetie
Copy link
Contributor

Here's a mockup:

image

"Database URL" should be renamed "Connection URL".

The default value of "Connection URL" field will be: bolt://localhost.

If the query string dbms is defined, we will use this value instead of the default value. For instance: https://neo4j.com/graphgists/northwind-recommendation-engine/?dbms=neo4j%2Bs://[email protected]
In this case, the value of the "Connection URL" field will be: neo4j+s://[email protected]

The connection URL will be used to update the link on the "Play as Browser Guide" button:

https://browser.neo4j.io/?cmd=play&arg=https://guides.neo4j.com/graph-examples/northwind-recommendation-engine/graph_guide&dbms={{connectionUrl}}

As you can see, the value of the field "Connection URL" is passed as a query string: &dbms={{connectionUrl}} (where {{connectionUrl}} is the connection URL filled out by the user).

Please note that we are now using https://browser.neo4j.io instead of neo4j-desktop://graphapps/neo4j-browser.

//cc @adam-cowley let me know what you think since you've worked on the original design.

@adam-cowley
Copy link
Collaborator

It looks OK in principle but I think I'd rather have Play as Browser Guide as a heading, then an input box for the URL and a button that says Play next to it. That way there is a clearer connection between the input box and the button

I'm also wondering if play is the best terminology for this too - maybe it should be Open in Neo4j Browser instead?

@adam-cowley
Copy link
Collaborator

While you have it open, could you also add some padding to the top of the Industries and Use Cases headers and around the button group please? 1em maybe? 😇

@ggrossetie
Copy link
Contributor Author

Great suggestions, will do 👍🏻

I'm also wondering if play is the best terminology for this too - maybe it should be Open in Neo4j Browser instead?

No strong opinion but a slight preference toward "Open in Neo4j Browser".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants