From 15a5d23814fb56e3301817d69f88d188f3c43dca Mon Sep 17 00:00:00 2001 From: Alex Chi Z Date: Mon, 2 Jun 2025 21:21:21 +0800 Subject: [PATCH 1/2] feat(pageserver): enable gc-compaction by default Signed-off-by: Alex Chi Z --- libs/pageserver_api/src/config.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libs/pageserver_api/src/config.rs b/libs/pageserver_api/src/config.rs index 444983bd18e3..51e1aa16082c 100644 --- a/libs/pageserver_api/src/config.rs +++ b/libs/pageserver_api/src/config.rs @@ -781,7 +781,7 @@ pub mod tenant_conf_defaults { // By default ingest enough WAL for two new L0 layers before checking if new image // image layers should be created. pub const DEFAULT_IMAGE_LAYER_CREATION_CHECK_THRESHOLD: u8 = 2; - pub const DEFAULT_GC_COMPACTION_ENABLED: bool = false; + pub const DEFAULT_GC_COMPACTION_ENABLED: bool = true; pub const DEFAULT_GC_COMPACTION_VERIFICATION: bool = true; pub const DEFAULT_GC_COMPACTION_INITIAL_THRESHOLD_KB: u64 = 5 * 1024 * 1024; // 5GB pub const DEFAULT_GC_COMPACTION_RATIO_PERCENT: u64 = 100; From be46676fac441c4c1c3bbb7a7ae871303f9dcdbf Mon Sep 17 00:00:00 2001 From: Alex Chi Z Date: Mon, 2 Jun 2025 22:40:13 +0800 Subject: [PATCH 2/2] fix fully customized config Signed-off-by: Alex Chi Z --- test_runner/regress/test_attach_tenant_config.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test_runner/regress/test_attach_tenant_config.py b/test_runner/regress/test_attach_tenant_config.py index 3eb6b7193ce9..78d0f139d7d3 100644 --- a/test_runner/regress/test_attach_tenant_config.py +++ b/test_runner/regress/test_attach_tenant_config.py @@ -188,7 +188,7 @@ def test_fully_custom_config(positive_env: NeonEnv): }, "rel_size_v2_enabled": True, "relsize_snapshot_cache_capacity": 10000, - "gc_compaction_enabled": True, + "gc_compaction_enabled": False, "gc_compaction_verification": False, "gc_compaction_initial_threshold_kb": 1024000, "gc_compaction_ratio_percent": 200,