Skip to content

Improve upgrade instructions #19502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
larsen0815 opened this issue May 15, 2025 · 3 comments · May be fixed by #19516
Open

Improve upgrade instructions #19502

larsen0815 opened this issue May 15, 2025 · 3 comments · May be fixed by #19516
Assignees
@larsen0815
Labels
status: accepted This issue has been accepted for implementation type: documentation A change or addition to the documentation

Comments

@larsen0815
Copy link

larsen0815 commented May 15, 2025 •
edited
Loading

Change Type

Addition

Area

Installation/upgrade

Proposed Changes

main...larsen0815:netbox:patch-2

Some minor changes:

  • Fix typo
  • As the version number is already automatically fetched from the repository, use this in a variable to more easily install that version
  • Explicitly change the directory so the user doesn't have to do this manually (any users not using the default installation directory should notice and adapt accordingly)
  • Use "git fetch" to prevent error: pathspec 'v4.3.1' did not match any file(s) known to git. This seems to be a common problem (1, 2, 3).
@larsen0815 larsen0815 added type: documentation A change or addition to the documentation status: needs triage This issue is awaiting triage by a maintainer labels May 15, 2025
@bctiemann
Copy link
Contributor

bctiemann commented May 15, 2025 •
edited
Loading

For simplicity, let's skip the assignment to $VERSION (let's avoid making the instructions too self-interdependent at the expense of clarity), but the other additional git commands are worth adding.

@bctiemann bctiemann added status: revisions needed This issue requires additional information to be actionable and removed status: needs triage This issue is awaiting triage by a maintainer labels May 15, 2025
@bctiemann bctiemann assigned bctiemann and larsen0815 and unassigned bctiemann May 15, 2025
@bctiemann bctiemann added status: accepted This issue has been accepted for implementation and removed status: revisions needed This issue requires additional information to be actionable labels May 15, 2025
@larsen0815 larsen0815 linked a pull request May 16, 2025 that will close this issue
Open
@larsen0815
Copy link
Author

I have removed the variable stuff and created #19516

@pheus
Copy link
Contributor

pheus commented May 16, 2025

This seems related to #16387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@larsen0815 larsen0815

Labels
status: accepted This issue has been accepted for implementation type: documentation A change or addition to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #19502: Improve upgrade instructions larsen0815/netbox
3 participants
@larsen0815 @bctiemann @pheus