Move LoadApplicationObjectFailedError up

Author: rmosolgo

lib/graphql.rb

@@ -106,3 +106,4 @@ def self.scan_with_ragel(graphql_string)
 require "graphql/authorization"
 require "graphql/unauthorized_error"
 require "graphql/unauthorized_field_error"
+require "graphql/load_application_object_failed_error"

lib/graphql/load_application_object_failed_error.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+module GraphQL
+  # Raised when a argument is configured with `loads:` and the client provides an `ID`,
+  # but no object is loaded for that ID.
+  #
+  # @see GraphQL::Schema::Member::HasArguments::ArgumentObjectLoader#load_application_object_failed, A hook which you can override in resolvers, mutations and input objects.
+  class LoadApplicationObjectFailedError < GraphQL::ExecutionError
+    # @return [GraphQL::Schema::Argument] the argument definition for the argument that was looked up
+    attr_reader :argument
+    # @return [String] The ID provided by the client
+    attr_reader :id
+    # @return [Object] The value found with this ID
+    attr_reader :object
+    def initialize(argument:, id:, object:)
+      @id = id
+      @argument = argument
+      @object = object
+      super("No object found for `#{argument.graphql_name}: #{id.inspect}`")
+    end
+  end
+end

lib/graphql/schema/member/has_arguments.rb

@@ -77,21 +77,6 @@ def argument_class(new_arg_class = nil)
         end
 
         module ArgumentObjectLoader
-          class LoadApplicationObjectFailedError < GraphQL::ExecutionError
-            # @return [GraphQL::Schema::Argument] the argument definition for the argument that was looked up
-            attr_reader :argument
-            # @return [String] The ID provided by the client
-            attr_reader :id
-            # @return [Object] The value found with this ID
-            attr_reader :object
-            def initialize(argument:, id:, object:)
-              @id = id
-              @argument = argument
-              @object = object
-              super("No object found for `#{argument.graphql_name}: #{id.inspect}`")
-            end
-          end
-
           # Look up the corresponding object for a provided ID.
           # By default, it uses Relay-style {Schema.object_from_id},
           # override this to find objects another way.
@@ -108,7 +93,7 @@ def load_application_object(argument, lookup_as_type, id)
             loaded_application_object = object_from_id(lookup_as_type, id, context)
             context.schema.after_lazy(loaded_application_object) do |application_object|
               if application_object.nil?
-                err = LoadApplicationObjectFailedError.new(argument: argument, id: id, object: application_object)
+                err = GraphQL::LoadApplicationObjectFailedError.new(argument: argument, id: id, object: application_object)
                 load_application_object_failed(err)
               end
               # Double-check that the located object is actually of this type
@@ -117,7 +102,7 @@ def load_application_object(argument, lookup_as_type, id)
               context.schema.after_lazy(resolved_application_object_type) do |application_object_type|
                 possible_object_types = context.schema.possible_types(lookup_as_type)
                 if !possible_object_types.include?(application_object_type)
-                  err = LoadApplicationObjectFailedError.new(argument: argument, id: id, object: application_object)
+                  err = GraphQL::LoadApplicationObjectFailedError.new(argument: argument, id: id, object: application_object)
                   load_application_object_failed(err)
                 else
                   # This object was loaded successfully

lib/graphql/schema/resolver.rb

@@ -300,4 +300,4 @@ def own_arguments_loads_as_type
       end
     end
   end
-end
+end

spec/graphql/schema/resolver_spec.rb

@@ -485,7 +485,7 @@ def exec_query(*args)
 
         res = exec_query(query_str)
         assert_nil res["data"].fetch("resolverWithErrorHandler")
-        expected_err = "ResolverWithErrorHandler failed for id: \"failed_to_find\" (nil) (GraphQL::Schema::Member::HasArguments::ArgumentObjectLoader::LoadApplicationObjectFailedError)"
+        expected_err = "ResolverWithErrorHandler failed for id: \"failed_to_find\" (nil) (GraphQL::LoadApplicationObjectFailedError)"
         assert_equal [expected_err], res["errors"].map { |e| e["message"] }
       end
     end
@@ -500,7 +500,7 @@ def exec_query(*args)
 
         res = exec_query(query_str)
         assert_nil res["data"].fetch("resolverWithErrorHandler")
-        expected_err = "ResolverWithErrorHandler failed for id: \"resolve_type_as_wrong_type\" (:resolve_type_as_wrong_type) (GraphQL::Schema::Member::HasArguments::ArgumentObjectLoader::LoadApplicationObjectFailedError)"
+        expected_err = "ResolverWithErrorHandler failed for id: \"resolve_type_as_wrong_type\" (:resolve_type_as_wrong_type) (GraphQL::LoadApplicationObjectFailedError)"
         assert_equal [expected_err], res["errors"].map { |e| e["message"] }
       end
     end