Merge pull request jupyterlab#368 from jaipreet-s/clonefix

Update clone to not use shell=True

Author: dleen

jupyterlab_git/git.py

@@ -78,7 +78,6 @@ def clone(self, current_path, repo_url):
         env['GIT_TERMINAL_PROMPT'] = '0'
         p = subprocess.Popen(
             ['git', 'clone', unquote(repo_url)],
-            shell=True,
             stdout=PIPE,
             stderr=PIPE,
             cwd=os.path.join(self.root_dir, current_path),

tests/unit/test_clone.py

@@ -27,7 +27,6 @@ def test_git_clone_success(mock_subproc_popen):
             stdout=PIPE,
             stderr=PIPE,
             cwd='/bin/test_curr_path',
-            shell=True,
             env={'TEST': 'test', 'GIT_TERMINAL_PROMPT': '0'},
         ),
         call().communicate()
@@ -62,7 +61,6 @@ def test_git_clone_failure_from_git(mock_subproc_popen):
             stdout=PIPE,
             stderr=PIPE,
             cwd='/bin/test_curr_path',
-            shell=True,
             env={'TEST': 'test', 'GIT_TERMINAL_PROMPT': '0'},
         ),
         call().communicate()