Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: primal100/pybitcointools
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: nicolas3355/pybitcointools
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 2 files changed
  • 1 contributor

Commits on Sep 9, 2023

  1. The code uses the vbytes to determine if the input key is private or … 

    …public.

However, it's only checking against MAINNET_PRIVATE by default, which can lead to issues if you're using testnet prefixes.

`private = (vbytes == prefixes[0])`
has been changed to
`private = vbytes in PRIVATE`

With this change, both mainnet (xprv) and testnet (tprv) private keys will be recognized correctly.
    @nicolas3355
    nicolas3355 committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    ae9b05d View commit details
    Browse the repository at this point in the history

  2. Updated bip32_deserialize and bip32_deserialized functions in determi… 

    …nistic.py to work with testnet.

Added testcase to test the deserialization and serialization for both mainnet and testnet.
To run the test go the root directory and run: `python -m unittest cryptos/testing/testcases_determinisitic.py`
    @nicolas3355
    nicolas3355 committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    588ae0b View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. added support for more version bytes

    @nicolas3355
    nicolas3355 committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    4053ad3 View commit details
    Browse the repository at this point in the history
Loading