Closes mozilla-mobile#3433: Disable periodic device event polling

Author: Grisha Kruglov

components/service/firefox-accounts/src/main/java/mozilla/components/service/fxa/manager/FxaAccountManager.kt

@@ -418,9 +418,6 @@ open class FxaAccountManager(
                             deviceTuple.name, deviceTuple.type, deviceTuple.capabilities
                         ).await()
 
-                        logger.info("Starting periodic refresh of the device constellation")
-                        account.deviceConstellation().startPeriodicRefresh()
-
                         notifyObservers { onAuthenticated(account) }
 
                         Event.FetchProfile
@@ -440,8 +437,11 @@ open class FxaAccountManager(
                             logger.warn("Failed to ensure device capabilities.")
                         }
 
-                        logger.info("Starting periodic refresh of the device constellation")
-                        account.deviceConstellation().startPeriodicRefresh()
+                        // We used to perform a periodic device event polling, but for now we do not.
+                        // This cancels any periodic jobs device may still have active.
+                        // See https://github.com/mozilla-mobile/android-components/issues/3433
+                        logger.info("Stopping periodic refresh of the device constellation")
+                        account.deviceConstellation().stopPeriodicRefresh()
 
                         notifyObservers { onAuthenticated(account) }
 
@@ -462,9 +462,6 @@ open class FxaAccountManager(
                                 deviceTuple.name, deviceTuple.type, deviceTuple.capabilities
                         ).await()
 
-                        logger.info("Starting periodic refresh of the device constellation")
-                        account.deviceConstellation().startPeriodicRefresh()
-
                         notifyObservers { onAuthenticated(account) }
 
                         Event.FetchProfile

components/service/firefox-accounts/src/test/java/mozilla/components/service/fxa/FxaAccountManagerTest.kt

@@ -182,8 +182,11 @@ class FxaAccountManagerTest {
         verify(constellation).ensureCapabilitiesAsync(listOf(DeviceCapability.SEND_TAB))
         verify(constellation, never()).initDeviceAsync(any(), any(), any())
 
-        // Assert that periodic account refresh started.
-        verify(constellation).startPeriodicRefresh()
+        // Assert that periodic account refresh never started.
+        // See https://github.com/mozilla-mobile/android-components/issues/3433
+        verify(constellation, never()).startPeriodicRefresh()
+        // Assert that we cancel any existing periodic jobs.
+        verify(constellation).stopPeriodicRefresh()
 
         // Assert that persistence callback is interacting with the storage layer.
         account.persistenceCallback!!.persist("test")
@@ -218,8 +221,9 @@ class FxaAccountManagerTest {
         verify(constellation).ensureCapabilitiesAsync(listOf(DeviceCapability.SEND_TAB))
         verify(constellation, never()).initDeviceAsync(any(), any(), any())
 
-        // Assert that periodic account refresh started.
-        verify(constellation).startPeriodicRefresh()
+        // Assert that periodic account refresh never started.
+        // See https://github.com/mozilla-mobile/android-components/issues/3433
+        verify(constellation, never()).startPeriodicRefresh()
 
         // Assert that persistence callback is interacting with the storage layer.
         account.persistenceCallback!!.persist("test")
@@ -339,8 +343,9 @@ class FxaAccountManagerTest {
         // Assert that persistence callback is set.
         assertNotNull(account.persistenceCallback)
 
-        // Assert that periodic account refresh started after finishing auth.
-        verify(constellation).startPeriodicRefresh()
+        // Assert that periodic account refresh is never started after finishing auth.
+        // See https://github.com/mozilla-mobile/android-components/issues/3433
+        verify(constellation, never()).startPeriodicRefresh()
 
         // Assert that initDevice fired, but not ensureCapabilities (since we're initing a new account).
         verify(constellation).initDeviceAsync(any(), any(), eq(listOf(DeviceCapability.SEND_TAB)))