Skip to content

Commit fa4bed6

Browse files
committed
Merge branch '2.4'
2 parents de204f6 + 9b49f2b commit fa4bed6

File tree

217 files changed

+21025
-19654
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

217 files changed

+21025
-19654
lines changed

.travis.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,14 @@
11
language: python
22
python:
3-
- "2.5"
43
- "2.6"
54
- "2.7"
65
env:
7-
- DJANGO=test_requirements/django-1.3.txt DB='sqlite://localhost/:memory:'
8-
- DJANGO=test_requirements/django-1.3.txt DB='mysql://[email protected]/djangocms_test'
9-
- DJANGO=test_requirements/django-1.3.txt DB='postgres://[email protected]/djangocms_test'
106
- DJANGO=test_requirements/django-1.4.txt DB='sqlite://localhost/:memory:'
117
- DJANGO=test_requirements/django-1.4.txt DB='mysql://[email protected]/djangocms_test'
128
- DJANGO=test_requirements/django-1.4.txt DB='postgres://[email protected]/djangocms_test'
9+
- DJANGO=test_requirements/django-1.5.txt DB='sqlite://localhost/:memory:'
10+
- DJANGO=test_requirements/django-1.5.txt DB='mysql://[email protected]/djangocms_test'
11+
- DJANGO=test_requirements/django-1.5.txt DB='postgres://[email protected]/djangocms_test'
1312

1413
before_script:
1514
- sh -c "if [ '$DB' = 'postgres://[email protected]/djangocms_test' ]; then psql -c 'DROP DATABASE IF EXISTS djangocms_test;' -U postgres; fi"

AUTHORS

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ Contributors (in alphabetical order):
2525
* Adrián Ribao
2626
* Alberto Paro
2727
* Alessandro Ronchi
28+
* Ales Zabala Alava (Shagi)
2829
* Aleš Kocjančič
2930
* Alex Cucu
3031
* Alexandre Leray
@@ -100,6 +101,7 @@ Contributors (in alphabetical order):
100101
* Iván Raskovsky
101102
* Ivan Vershigora
102103
* izi
104+
* J. Cliff Dyer
103105
* Jacob Rief
104106
* Jameel Al-Aziz
105107
* James Richards
@@ -126,6 +128,7 @@ Contributors (in alphabetical order):
126128
* Lars Smit
127129
* Lars van de Kerkhof
128130
* limpbrains :P
131+
* littlepea
129132
* Lucas Vogelsang
130133
* Lucio Asnaghi
131134
* Luke Crooks
@@ -134,6 +137,7 @@ Contributors (in alphabetical order):
134137
* Maik Lustenberger
135138
* Manolis Stamatogiannakis
136139
* Manuel Schmidt
140+
* Marc-Olivier Titeux
137141
* Marco Bonetti
138142
* Marco Rimoldi
139143
* Mark Rogers
@@ -150,9 +154,10 @@ Contributors (in alphabetical order):
150154
* Mel Collins
151155
* meers
152156
* MerLex
153-
* Mokys
157+
* Michael P. Jung
154158
* Mike Johnson
155159
* Mitar
160+
* Mokys
156161
* mrlundis
157162
* MW
158163
* neoprolog
@@ -163,6 +168,8 @@ Contributors (in alphabetical order):
163168
* Pascal Mouret
164169
* Patrick Toal
165170
* Paul van der Linden
171+
* Paulo
172+
* Paulo Alvarado
166173
* Pavel Puchkin
167174
* pbgc
168175
* Pedro Gracia
@@ -197,6 +204,7 @@ Contributors (in alphabetical order):
197204
* Shatalov Vadim
198205
* shed
199206
* Shinya Okano
207+
* shulcsm
200208
* Simon Hedberg
201209
* Simon Meers
202210
* Simon Charette
@@ -214,6 +222,7 @@ Contributors (in alphabetical order):
214222
* Tim Davies
215223
* Tino de Bruijn
216224
* tiret
225+
* Tom de Simone
217226
* Ulrich Petri
218227
* Vasil Vangelovski
219228
* Viliam Segeda

CHANGELOG.txt

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,10 @@
122122

123123
Please see Install/2.4 release notes *before* attempting to upgrade to version 2.4.
124124

125+
- Compatibility with Django 1.4 and 1.5 (1.3 support dropped)
126+
- Support for Python 2.5 dropped
127+
- CMS_MAX_PAGE_PUBLISH_REVERSIONS has been added
128+
- Reversion integration has changed to limit DB size
125129
- CMS_LANGUAGE setting has changed
126130
- CMS_HIDE_UNTRANSLATED setting removed
127131
- CMS_LANGUAGE_FALLBACK setting removed
@@ -130,6 +134,5 @@ Please see Install/2.4 release notes *before* attempting to upgrade to version 2
130134
- CMS_FRONTEND_LANGUAGES setting removed
131135
- MultilingualMiddleware has been removed
132136
- CMS_FLAT_URLS has been removed
137+
- PlaceholderAdmin has now language tabs and has support for django-hvad
133138

134-
==== NEXT ====
135-
- Fixed #1543: Nasty empty line in cms/plugins/link.html

cms/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
# -*- coding: utf-8 -*-
2-
__version__ = '2.4.0.beta'
2+
__version__ = '2.4.0.RC1'
33

cms/admin/forms.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
from cms.apphook_pool import apphook_pool
44
from cms.forms.widgets import UserSelectAdminWidget
55
from cms.models import (Page, PagePermission, PageUser, ACCESS_PAGE,
6-
PageUserGroup)
6+
PageUserGroup, titlemodels)
77
from cms.utils.conf import get_cms_setting
88
from cms.utils.i18n import get_language_tuple, get_language_list
99
from cms.utils.mail import mail_page_user_change
@@ -116,8 +116,11 @@ def clean(self):
116116
#Check for titles attached to the page makes sense only because
117117
#AdminFormsTests.test_clean_overwrite_url validates the form with when no page instance available
118118
#Looks like just a theoretical corner case
119-
title = page.get_title_obj(lang)
120-
if title and slug:
119+
try:
120+
title = page.get_title_obj(lang, fallback=False)
121+
except titlemodels.Title.DoesNotExist:
122+
title = None
123+
if title and not isinstance(title, titlemodels.EmptyTitle) and slug:
121124
oldslug = title.slug
122125
title.slug = slug
123126
title.save()

0 commit comments

Comments
 (0)