-
-
Notifications
You must be signed in to change notification settings - Fork 477
Test failures on AIX #1654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'm not sure yet what path has led to installing https://github.com/un-ts/napi-postinstall is new (created on the same 19 April 2025) and it probably doesn't know what to do with AIX, e.g. https://github.com/un-ts/napi-postinstall/blob/b2917626cf9f315afed00384a25354a7958848f9/src/helpers.ts#L170-L249. |
This seems to be the related npm tree that pulls it in:
|
neostandard has been pulled in for quite some time (at least 5 months or longer) and was last updated 4 months ago. |
In eslint-import-resolver-typescript is says - "unrs-resolver": "^1.6.2" so it does make sense we'd be pulling in the changes @richardlau pointed to earlier and that would be causing the issue. |
Checking to see if a short term work around might be to make sure we don't install dev dependencies in the CI job. |
@abmusse could you take a look at PRing in the case needed for AIX into unrs-resolver? |
@mhdawson another short term work around might be using npm overrides to downgrade unrs-resolver. |
Added the part which strips neostandard from the list of deps in an existing block for aix as follows: if [ $OS == "aix" ]; then
# otherwise the default shell is used and we may get errors about "--" not being supported
npm config set script-shell "bash"
mv package.json package.json.org
cat package.json.org |grep -v neostandard >package.json
fi Tests passes. I think that is a reasonable work around until we can get unrs fixed up. @richardlau the overrides is a good suggestion as well, but I think I'll leave it at the fix in the job as that will avoid having to remove the override later on. Will leave this issue open so we don't forget to follow up on the fix in unrs-resolver. |
Passing test run - https://ci.nodejs.org/job/node-test-node-addon-api-new/10229/ |
Since April 19 there seem to be test failures on AIX - https://ci.nodejs.org/view/x%20-%20Abi%20stable%20module%20API/job/node-test-node-addon-api-new/nodes=aix72-ppc64/10225/console
They seems to be at the npm install step:
The text was updated successfully, but these errors were encountered: