Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: noxdafox/rabbitmq-message-deduplication
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: noxdafox/rabbitmq-message-deduplication
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.7.x
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 8 commits
  • 6 files changed
  • 1 contributor

Commits on Feb 11, 2020

  1. Makefile: enforce RMQ version v3.7.16

    Signed-off-by: Matteo Cafasso <[email protected]>
    noxdafox committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    2e666e1 View commit details
    Browse the repository at this point in the history
  2. issue #52: add test case for dead lettering

    Signed-off-by: Matteo Cafasso <[email protected]>
    noxdafox committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    85a67ec View commit details
    Browse the repository at this point in the history
  3. issue #52: remove rejected messages from queue deduplication cache

    Signed-off-by: Matteo Cafasso <[email protected]>
    noxdafox committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    512ac3a View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2020

  1. mix: release 0.4.4

    Signed-off-by: Matteo Cafasso <[email protected]>
    noxdafox committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    5b5eb01 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2020

  1. issue #49, #55, #58: ensure mnesia cache persistence over node failures

    The deduplication cache was created on the node where the
    resource (exchange or queue) was initialized.
    
    If the node crashed and was replaced mnesia could not recover or
    recreate the table used as a cache.
    
    After several attempts, it seems the best way to prevent this from
    happening is to replicate the table over more nodes to ensure mnesia
    can recover it in case of a node disappearing.
    
    To ensure safe enough persistence without replicating too
    aggressively, the cache is created on 2/3 of the total cluster nodes.
    
    Signed-off-by: Matteo Cafasso <[email protected]>
    noxdafox committed May 26, 2020
    Configuration menu
    Copy the full SHA
    5b358d2 View commit details
    Browse the repository at this point in the history
  2. queue: remove cache persistence

    RabbitMQ classic queue supports both transient and persistent messages
    on the same queue. If a node where a queue relies crashes, transient
    messages will be lost whereas persistent will remain.
    
    It is unfortunately non-trivial from the plugin to access to
    presistent messages at recover. On the other side, persisting
    deduplication headers would be dangerous as we might deduplicate lost
    transient messages forever in case of recovery.
    
    The easiest solution is, for now, to flush the cache at startup.
    
    Signed-off-by: Matteo Cafasso <[email protected]>
    noxdafox committed May 26, 2020
    Configuration menu
    Copy the full SHA
    51377fb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    628ea48 View commit details
    Browse the repository at this point in the history
  4. mix: release 0.4.5

    Signed-off-by: Matteo Cafasso <[email protected]>
    noxdafox committed May 26, 2020
    Configuration menu
    Copy the full SHA
    a25d0de View commit details
    Browse the repository at this point in the history
Loading