-
Notifications
You must be signed in to change notification settings - Fork 37
Comparing changes
Open a pull request
base repository: noxdafox/rabbitmq-message-deduplication
base: main
head repository: noxdafox/rabbitmq-message-deduplication
compare: v3.7.x
- 8 commits
- 6 files changed
- 1 contributor
Commits on Feb 11, 2020
-
Makefile: enforce RMQ version v3.7.16
Signed-off-by: Matteo Cafasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2e666e1 - Browse repository at this point
Copy the full SHA 2e666e1View commit details -
issue #52: add test case for dead lettering
Signed-off-by: Matteo Cafasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 85a67ec - Browse repository at this point
Copy the full SHA 85a67ecView commit details -
issue #52: remove rejected messages from queue deduplication cache
Signed-off-by: Matteo Cafasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 512ac3a - Browse repository at this point
Copy the full SHA 512ac3aView commit details
Commits on Feb 12, 2020
-
Signed-off-by: Matteo Cafasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5b5eb01 - Browse repository at this point
Copy the full SHA 5b5eb01View commit details
Commits on May 26, 2020
-
issue #49, #55, #58: ensure mnesia cache persistence over node failures
The deduplication cache was created on the node where the resource (exchange or queue) was initialized. If the node crashed and was replaced mnesia could not recover or recreate the table used as a cache. After several attempts, it seems the best way to prevent this from happening is to replicate the table over more nodes to ensure mnesia can recover it in case of a node disappearing. To ensure safe enough persistence without replicating too aggressively, the cache is created on 2/3 of the total cluster nodes. Signed-off-by: Matteo Cafasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5b358d2 - Browse repository at this point
Copy the full SHA 5b358d2View commit details -
queue: remove cache persistence
RabbitMQ classic queue supports both transient and persistent messages on the same queue. If a node where a queue relies crashes, transient messages will be lost whereas persistent will remain. It is unfortunately non-trivial from the plugin to access to presistent messages at recover. On the other side, persisting deduplication headers would be dangerous as we might deduplicate lost transient messages forever in case of recovery. The easiest solution is, for now, to flush the cache at startup. Signed-off-by: Matteo Cafasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 51377fb - Browse repository at this point
Copy the full SHA 51377fbView commit details -
README: deprecate
x-cache-persistence
parameter on queue deduplicationSigned-off-by: Matteo Cafasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 628ea48 - Browse repository at this point
Copy the full SHA 628ea48View commit details -
Signed-off-by: Matteo Cafasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a25d0de - Browse repository at this point
Copy the full SHA a25d0deView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff main...v3.7.x