Skip to content

Deduplication-0.6.4 crash with rabbitmq 4.0.6 #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nicolas-lacombe-hf opened this issue Feb 19, 2025 · 9 comments
Closed

Deduplication-0.6.4 crash with rabbitmq 4.0.6 #115

nicolas-lacombe-hf opened this issue Feb 19, 2025 · 9 comments

Comments

@nicolas-lacombe-hf
Copy link

Hello

Deduplication plugin-0.6.4 doesn't seem to work anymore with rabbitmq v4.0.6.
even though the hashes are the same, the messages are added to the queue, and in the logs I see that it crashes.

Note: The plugin worked fine with rabbitmq v4.0.5.

Here is the crash log with rabbitmq v4.0.6:

Deduplication-0.6.4-Error-with-rabbitmq-v4.0.6.log

@gomoripeti
Copy link
Contributor

thanks for bringing this up.

this is related to issue #106 addressed with a change in RabbitMQ rabbitmq/rabbitmq-server#12913 (released in 4.0.6)
The related necessary change in this plugin is already in main bdedc84, but it is not yet included in a plugin release.

(in hindsight maybe it would have been better not to introduce a backing queue behaviour change in a patch release but wait for 4.1.0)

@noxdafox
Copy link
Owner

I was hoping to get this merged before doing a release. Will ask what's the status of this PR.

@nicolas-lacombe-hf
Copy link
Author

Thank you for your work, we are waiting for the next release.

Should I close this ticket now or will you close it when the release is done?

@noxdafox
Copy link
Owner

I usually close the tickets once the release fixing the issue is out. Don't worry. 😄

@paro-
Copy link

paro- commented Apr 8, 2025

Hello,
Could you please clarify if/when the plugin will be available for RabbitMQ 4.0.6+?
Thanks, good day,
Paul

@pabermod
Copy link

pabermod commented Apr 10, 2025

@nicolas-lacombe-hf for me it seems to be working with latest version RabbitMQ 4.0.8 and Erlang 27.3.2, can you give it a try?

I'm trying with Exchange level deduplication because i use quorum queues

Regards

@paro-
Copy link

paro- commented May 2, 2025

Hi,
Any news on this please?
I saw that RabbitMQ 4.1.0 was out, wonder what's the status of the dedup plugin with that version as well.
Best regards.

@nicolas-lacombe-hf
Copy link
Author

@nicolas-lacombe-hf for me it seems to be working with latest version RabbitMQ 4.0.8 and Erlang 27.3.2, can you give it a try?

I'm trying with Exchange level deduplication because i use quorum queues

Regards

@pabermod
Sorry, I couldn't test it sooner. Yes, it seems to be working again with rabbitmq 4.0.8. Thx.

But we've upgraded to version 3.13. We'll probably see in a few months whether to do another run and test version 4.1.

Best regards.

@noxdafox
Copy link
Owner

noxdafox commented May 5, 2025

New version 0.7.0 should now support v3.13, v4.0 and v4.1. Please re-open this ticket if any issue persists.

@noxdafox noxdafox closed this as completed May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants