fix(PermissionError): Make file executable before running the app. (microsoft#222)

Author: ycd

playwright/main.py

@@ -14,8 +14,6 @@
 
 import asyncio
 import io
-import os
-import stat
 import subprocess
 import sys
 from pathlib import Path
@@ -27,7 +25,7 @@
 from playwright.connection import Connection
 from playwright.helper import Error
 from playwright.object_factory import create_remote_object
-from playwright.path_utils import get_file_dirname
+from playwright.path_utils import get_file_dirname, make_file_executable
 from playwright.playwright import Playwright
 from playwright.sync_api import Playwright as SyncPlaywright
 from playwright.sync_base import dispatcher_fiber, set_dispatcher_fiber
@@ -37,15 +35,19 @@ def compute_driver_executable() -> Path:
     package_path = get_file_dirname()
     platform = sys.platform
     if platform == "darwin":
-        return package_path / "drivers" / "driver-darwin"
+        path = package_path / "drivers" / "driver-darwin"
+        return make_file_executable(path)
     elif platform == "linux":
-        return package_path / "drivers" / "driver-linux"
+        path = package_path / "drivers" / "driver-linux"
+        return make_file_executable(path)
     elif platform == "win32":
         result = package_path / "drivers" / "driver-win32-amd64.exe"
         if result.exists():
             return result
         return package_path / "drivers" / "driver-win32.exe"
-    return package_path / "drivers" / "driver-linux"
+
+    path = package_path / "drivers" / "driver-linux"
+    return make_file_executable(path)
 
 
 async def run_driver_async() -> Connection:
@@ -140,11 +142,7 @@ def main() -> None:
         print('Run "python -m playwright install" to complete installation')
         return
     driver_executable = compute_driver_executable()
-    # Fix the executable bit during the installation.
-    if not sys.platform == "win32":
-        st = os.stat(driver_executable)
-        if st.st_mode & stat.S_IEXEC == 0:
-            os.chmod(driver_executable, st.st_mode | stat.S_IEXEC)
+
     print("Installing the browsers...")
     subprocess.check_call([str(driver_executable), "install"])
 

playwright/path_utils.py

@@ -1,4 +1,5 @@
 import inspect
+import stat
 from pathlib import Path
 
 
@@ -8,3 +9,9 @@ def get_file_dirname() -> Path:
     module = inspect.getmodule(frame[0])
     assert module
     return Path(module.__file__).parent.absolute()
+
+
+def make_file_executable(file_path: Path) -> Path:
+    """Makes a file executable."""
+    file_path.chmod(file_path.stat().st_mode | stat.S_IEXEC)
+    return file_path