Skip to content

Extend provable events in the block metadata transaction #6210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
peternose opened this issue May 30, 2025 · 3 comments
Open

Extend provable events in the block metadata transaction #6210

peternose opened this issue May 30, 2025 · 3 comments
Assignees
Labels
c:breaking/consensus Category: breaking consensus changes c:breaking Category: breaking code change

Comments

@peternose
Copy link
Contributor

peternose commented May 30, 2025

Last results hash is needed if a stateless light node wants to verify events from the last block.

Provable events need to be extended if a stateless light node wants to verify events from the last block.

@peternose peternose self-assigned this May 30, 2025
@peternose peternose added the c:breaking Category: breaking code change label May 30, 2025
@peternose peternose changed the title Add last results results hash to the block metadata transaction Add last results hash to the block metadata transaction May 30, 2025
@kostko
Copy link
Member

kostko commented May 31, 2025

Should we instead extend what events are included in the existing provable events root?

@peternose
Copy link
Contributor Author

In that case, we need to make events from all services provable, i.e. events from beacon, roothash, registry, staking, ..., vault. Furthermore, a stateless node cannot verify response from GetBlockResults for the last height (unless we change this by filtering only provable events). And the change is still breaking.

@kostko kostko added the c:breaking/consensus Category: breaking consensus changes label May 31, 2025
@kostko
Copy link
Member

kostko commented Jun 1, 2025

I believe events are missing from LastResultsHash, see the canonicalization function which excludes events. This is why we needed to add the provable events root in the first place.

@peternose peternose changed the title Add last results hash to the block metadata transaction Extend provable events in the block metadata transaction Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:breaking/consensus Category: breaking consensus changes c:breaking Category: breaking code change
Projects
None yet
Development

No branches or pull requests

2 participants