Directly check the map bounds instead of converting to PPos

abcdefg30 · teinarss · commit 173aae1f8139 · 2020-07-08T18:37:50.000+02:00
diff --git a/OpenRA.Game/Map/Map.cs b/OpenRA.Game/Map/Map.cs
@@ -810,8 +810,9 @@ public bool Contains(MPos uv)
 
 		bool ContainsAllProjectedCellsCovering(MPos uv)
 		{
+			// PERF: Checking the bounds directly here is the same as calling Contains((PPos)uv) but saves an allocation
 			if (Grid.MaximumTerrainHeight == 0)
-				return Contains((PPos)uv);
+				return Bounds.Contains(uv.U, uv.V);
 
 			// If the cell has no valid projection, then we're off the map.
 			var projectedCells = ProjectedCellsCovering(uv);

Original file line number	Diff line number	Diff line change
`@@ -810,8 +810,9 @@ public bool Contains(MPos uv)`
`810`	`810`
`811`	`811`	`bool ContainsAllProjectedCellsCovering(MPos uv)`
`812`	`812`	`{`
	`813`	`+ // PERF: Checking the bounds directly here is the same as calling Contains((PPos)uv) but saves an allocation`
`813`	`814`	`if (Grid.MaximumTerrainHeight == 0)`
`814`		`- return Contains((PPos)uv);`
	`815`	`+ return Bounds.Contains(uv.U, uv.V);`
`815`	`816`
`816`	`817`	`// If the cell has no valid projection, then we're off the map.`
`817`	`818`	`var projectedCells = ProjectedCellsCovering(uv);`