Skip to content

Commit 0a80d3c

Browse files
officertofficert
committed
fix issue with adding and removing classes
1 parent e287484 commit 0a80d3c

File tree

8 files changed

+12
-13
lines changed

8 files changed

+12
-13
lines changed

‎dist/vue2-slideout-panel.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/vue2-slideout-panel.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎docs-src/components/Home/index.vue

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,8 @@ export default {
6565
showPanel3() {
6666
const handle = this.$showPanel({
6767
width: 700,
68-
component: 'panel-3'
68+
component: 'panel-3',
69+
class: 'foobar'
6970
});
7071
7172
handle.promise

‎docs-src/components/Home/template.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ <h2 class="project-tagline">
1616
</div>
1717
<div class="demo-btn">
1818
<button class="btn btn-xl" @click.prevent="showPanel3">
19-
Demo
19+
Demo 222
2020
</button>
2121
</div>
2222
</section>

‎docs/docs.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎docs/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
<link rel="icon" href="https://vuejs.org/images/logo.png" type="image/png">
3737
</head>
3838

39-
<body>
39+
<body class="class-1 class-2">
4040
<div id="app"></div>
4141
<script src="docs.js"></script>
4242
</body>

‎package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "vue2-slideout-panel",
3-
"version": "2.4.0",
3+
"version": "2.5.0",
44
"description": "Lib for creating stackable panels using Vue JS",
55
"main": "dist/vue2-slideout-panel.js",
66
"scripts": {

‎src/domUtils.js

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
11
function addClass(element, className) {
2-
removeClass(element, className);
3-
4-
element.className += ` ${className}`;
2+
element.classList.remove(className);
3+
element.classList.add(className);
54
}
65

76
function removeClass(element, className) {
8-
const regex = new RegExp(`(?:^|\\s)${className}(?:\\s|$)`);
9-
element.className = element.className.replace(regex, '');
7+
element.classList.remove(className);
108
}
119

1210
export default {

0 commit comments

Comments
 (0)