Skip to content

Commit 0ccccab

Browse files
committed
wonky bug if you don't create a new object for defaults
1 parent d5586bd commit 0ccccab

File tree

7 files changed

+13
-11
lines changed

7 files changed

+13
-11
lines changed

dist/vue-slideout-panel.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*!
2-
* vue2-slideout-panel v2.11.0 (https://github.com/officert/vue-slideout-panel)
2+
* vue2-slideout-panel v2.12.0 (https://github.com/officert/vue-slideout-panel)
33
* (c) 2020 Tim Officer
44
* Released under the MIT License.
55
*/
@@ -12266,10 +12266,11 @@ var vm = {
1226612266
return panel.removeBg;
1226712267
}).length > 0;
1226812268
},
12269-
panelTopVisibleZindex: function panelTopVisibleZindex() {
12269+
panelTopVisibleZIndex: function panelTopVisibleZIndex() {
1227012270
var visiblePanels = this.panels.filter(function (panel) {
1227112271
return panel.visible;
1227212272
});
12273+
1227312274
return visiblePanels.length > 0 ? Math.max.apply(Math, (0, _toConsumableArray3.default)(visiblePanels.map(function (panel) {
1227412275
return panel.styles['z-index'];
1227512276
}))) : Z_INDEX_BASE;
@@ -13260,7 +13261,7 @@ module.exports={render:function (){var _vm=this;var _h=_vm.$createElement;var _c
1326013261
'transparent': !_vm.panelBgVisible
1326113262
},
1326213263
style: ({
13263-
'z-index': _vm.panelTopVisibleZindex
13264+
'z-index': _vm.panelTopVisibleZIndex
1326413265
}),
1326513266
on: {
1326613267
"click": _vm.onBgClicked
@@ -13391,7 +13392,7 @@ function showPanel(panelOptions, existingId) {
1339113392

1339213393
var id = existingId || _utils2.default.generateGuid();
1339313394

13394-
panelOptions = (0, _assign2.default)(PANEL_DEFAULTS, panelOptions);
13395+
panelOptions = (0, _assign2.default)({}, PANEL_DEFAULTS, panelOptions);
1339513396

1339613397
panelOptions.id = id;
1339713398
panelOptions.openOn = panelOptions.openOn || 'left';

dist/vue-slideout-panel.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/docs.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "vue2-slideout-panel",
3-
"version": "2.11.0",
3+
"version": "2.12.0",
44
"description": "Lib for creating stackable panels using Vue JS",
55
"main": "dist/vue-slideout-panel.js",
66
"scripts": {

src/components/SlideoutPanel/index.vue

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,9 @@ const vm = {
3333
panelBgRemoved() {
3434
return this.panels.filter(panel => panel.removeBg).length > 0;
3535
},
36-
panelTopVisibleZindex() {
36+
panelTopVisibleZIndex() {
3737
const visiblePanels = this.panels.filter(panel => panel.visible);
38+
3839
return (visiblePanels.length > 0) ? Math.max(...visiblePanels.map(panel => panel.styles['z-index'])) : Z_INDEX_BASE;
3940
}
4041
},

src/components/SlideoutPanel/template.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<transition name="fadeIn">
22
<div class="slideout-panel clearfix">
33
<transition name="fadeIn">
4-
<div class="slideout-panel-bg" @click="onBgClicked" :class="{ 'transparent' : !panelBgVisible }" :style="{ 'z-index' : panelTopVisibleZindex }" v-if="panelsVisible && !panelBgRemoved">
4+
<div class="slideout-panel-bg" @click="onBgClicked" :class="{ 'transparent' : !panelBgVisible }" :style="{ 'z-index' : panelTopVisibleZIndex }" v-if="panelsVisible && !panelBgRemoved">
55
</div>
66
</transition>
77
<transition-group class="slideout-wrapper" tag="div" name="slideIn">

src/service.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ function showPanel(panelOptions, existingId) {
4545

4646
const id = existingId || utils.generateGuid();
4747

48-
panelOptions = Object.assign(PANEL_DEFAULTS, panelOptions);
48+
panelOptions = Object.assign({}, PANEL_DEFAULTS, panelOptions);
4949

5050
panelOptions.id = id;
5151
panelOptions.openOn = panelOptions.openOn || 'left';

0 commit comments

Comments
 (0)