This is actually caused by a transitive dependency. We specify [email protected] in package.json, which is what pulls in yargs using a git:// URL:

"git://github.com/boneskull/yargs#nylen"

Modifications to yarn.lock will be overwritten the next time a build happens. We've worked around this for Docker builds here and here, but this unfortunately does not cover non-Docker builds.

The ideal solution here is probably to replace the usage of j2j throughout the codebase, though this is a slightly larger task. The j2j library is used in these places:

app/data/utils/node_fx_converter.js
app/data/utils/refactor_animations.js
app/data/utils/refactor_card_factory.js # imported but not used
scripts/generate_packages.js

The library itself is fairly small, and we could probably replace it with a small amount of code internally. The only function we use from this library is output().

There is actually a solid chance we can simply replace these calls with JSON.stringify(input, null, 10), based on the code. @adam-jennings want to give this a shot? If not I can check it out sometime this week.

To clarify, the full process would be:

• Replace j2j.output(input) calls with JSON.stringify(input, null, 10) calls.
• Remove imports of j2j.
• Remove j2j from package.json.
• Run yarn build to regenerate yarn.lock, and ensure git:// is gone.
• Remove the Docker workarounds linked above.
• Make sure everything seems to work! As long as it builds and plays in-browser, we're probably good to go.

Yeah I'd be willing to try that!