improvements

[johnpetersa19]

I had the freedom to improve the project's graphics and I would really like you to see and apply these improvements. This will make the project more beautiful.

[bgoglin]

Hello. Where is the corresponding code ?

[johnpetersa19]

Good morning. This chart doesn't exist as-is — I improved it manually. I used the command lstopo --output-format svg and then edited the result.

It is a suggestion for improvement to make the graph more beautiful.

[bgoglin]

OK. Colors may already be changed with things like --palette to change the color of a kind of objects, or even object specific attributes. For other things, we cannot modify the SVG output as is because it's generated from a generic infrastructure that builds lots of different outputs (cairo for X11/SVG/PNG/PDS/PDF, ascii with ncurses, tikz for Latex, Windows etc). Regarding PCI, you should look at more complex examples generated from servers because they bring additional constraints (eg https://www.open-mpi.org/projects/hwloc/lstopo/images/2XeonSPv2+dax+pmem.v2.1.png)

[sthibaul]

"beautiful" is a relative concept, it's a matter of tastes and colours :)

I don't think that by default we want to set a lot of colours, and rather be informative in simple ways.

I'd rather not move the OS devices outside their PCI card: most often the device is really on the card, and not connected to it (and it's better to avoid confusing inclusion into the card above or below).

I'm wondering about the block around the PCI cards. It could make sense to add such block for PCI cards connected through the same host bridge, but I'm really unsure this helps with readability.