Skip to content

Commit 37a2dc8

Browse files
author
programarivm
committed
Refactored AbstractEvaluation
1 parent 545d5fc commit 37a2dc8

File tree

2 files changed

+26
-25
lines changed

2 files changed

+26
-25
lines changed

src/Evaluation/AbstractEvaluation.php

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
use Chess\Board;
66
use Chess\PGN\AN\Color;
77
use Chess\PGN\AN\Piece;
8+
use Chess\Piece\AbstractPiece;
89

910
/**
1011
* Abstract evaluation.
@@ -33,4 +34,29 @@ public function __construct(Board $board)
3334
Piece::Q => 8.8,
3435
];
3536
}
37+
38+
protected function attackedPieces(AbstractPiece $piece): array
39+
{
40+
$attackedPieces = [];
41+
foreach ($sqs = $piece->getSqs() as $sq) {
42+
if ($attackedPiece = $this->board->getPieceBySq($sq)) {
43+
if ($attackedPiece->getId() !== Piece::P) {
44+
$attackedPieces[] = $attackedPiece;
45+
}
46+
}
47+
}
48+
49+
return $attackedPieces;
50+
}
51+
52+
protected function isKingAttacked(array $attackedPieces): bool
53+
{
54+
foreach ($attackedPieces as $attackedPiece) {
55+
if ($attackedPiece->getId() === Piece::K) {
56+
return true;
57+
}
58+
}
59+
60+
return false;
61+
}
3662
}

src/Evaluation/AbstractForkEvaluation.php

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -7,31 +7,6 @@
77

88
abstract class AbstractForkEvaluation extends AbstractEvaluation
99
{
10-
protected function attackedPieces(AbstractPiece $piece): array
11-
{
12-
$attackedPieces = [];
13-
foreach ($sqs = $piece->getSqs() as $sq) {
14-
if ($attackedPiece = $this->board->getPieceBySq($sq)) {
15-
if ($attackedPiece->getId() !== Piece::P) {
16-
$attackedPieces[] = $attackedPiece;
17-
}
18-
}
19-
}
20-
21-
return $attackedPieces;
22-
}
23-
24-
protected function isKingAttacked(array $attackedPieces): bool
25-
{
26-
foreach ($attackedPieces as $attackedPiece) {
27-
if ($attackedPiece->getId() === Piece::K) {
28-
return true;
29-
}
30-
}
31-
32-
return false;
33-
}
34-
3510
protected function sumValues(AbstractPiece $piece, array $attackedPieces)
3611
{
3712
$values = 0;

0 commit comments

Comments
 (0)