Skip to content

BC-breaking pytorch 1.9 vs 1.7.1 in multi_head_attention_forward #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Zhaoyi-Yan opened this issue Jan 18, 2023 · 1 comment
Closed

BC-breaking pytorch 1.9 vs 1.7.1 in multi_head_attention_forward #312

Zhaoyi-Yan opened this issue Jan 18, 2023 · 1 comment

Comments

@Zhaoyi-Yan
Copy link

https://github.com/pytorch/pytorch/blob/v1.7.1/torch/nn/functional.py#L4222

https://github.com/pytorch/pytorch/blob/v1.9.0/torch/nn/functional.py#L4836

I cannot find scaling in pytorch 1.9, it seems has been removed. So, maybe First, [install PyTorch 1.7.1](https://pytorch.org/get-started/locally/) (or later) and torchvision is not correct.
@jongwook
Copy link
Collaborator

It appears that they refactored the implementation, and the scaling part is now in:

https://github.com/pytorch/pytorch/blob/v1.9.0/torch/nn/functional.py#L4823

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jongwook @Zhaoyi-Yan