Skip to content

Life Leech Calc #3536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 4 tasks
myallith opened this issue May 17, 2025 · 7 comments · Fixed by #3539
Closed
2 of 4 tasks

Life Leech Calc #3536

myallith opened this issue May 17, 2025 · 7 comments · Fixed by #3539
Labels
Priority: Low Minor impact Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@myallith
Copy link
Contributor

myallith commented May 17, 2025

Priority

High

Area

  • Datapack
  • Source
  • Map
  • Other

What happened?

Versão mais recente!

I noticed there's an issue with life leech, as the calculation doesn't work properly. For example:
Notei que existe um problema com o life leech, assim o calculo não funciona adequadamente por exemplo:

Tibia Global:
07:24 You see a soulhexer (magic level +5, life leech +5%, mana leech +3%, protection ice +12%).
Imbuements: (Empty Slot, Empty Slot).
Classification: 4 Tier: 0.
It can only be wielded properly by druids of level 400 or higher.
It weighs 25.00 oz.

Canary:
07:26 You see a soulhexer (life leech chance +1%, life leech amount +5%, mana leech chance +1%, mana leech amount +3%, magic level +5, protection ice +12%).
It can only be wielded properly by druids of level 400 or higher.
Imbuements: (Empty Slot, Empty Slot).
Classification: 4 Tier: 0
It weighs 25.00 oz.

After this, this calc is correct?
Image

@myallith myallith added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label May 17, 2025
@github-actions github-actions bot added Priority: High Represent a high impact in key areas of the base/user experience Status: Pending Test This PR or Issue requires more testing labels May 17, 2025
@mdbeng
Copy link
Contributor

mdbeng commented May 18, 2025

The way mana leech and life leech works is that you return true % of damage dealt. Then u retrieve the 5% of the true % damage dealt.

Its not from what u see since theres things implicated such as level, etc etc.

So lets say u hit 1 monster a true damage of 100. Then the mana u get back out of it from 5% its 0.5 mana

That being said if u hit 8 monsters u do the math. So no it's not from the hit u see. Because imagine a ek with double imbuement + equipment that means he would heal around 1500 hp per exori.

@murilo09
Copy link
Contributor

murilo09 commented May 18, 2025

It’s just showing the wrong value, but it’s correct. Remove the chance from items.xml

@mdbeng
Copy link
Contributor

mdbeng commented May 18, 2025

I understand, u can make a PR with the changes, but i thought u were asking about the calculation.

Or if u rather I could do it

It’s just showing the wrong value, but it’s correct. Remove the chance from items.xml

@murilo09 murilo09 added Priority: Low Minor impact and removed Priority: High Represent a high impact in key areas of the base/user experience Status: Pending Test This PR or Issue requires more testing labels May 19, 2025
@murilo09 murilo09 mentioned this issue May 19, 2025
8 tasks
@murilo09
Copy link
Contributor

@myallith please check PR #3539

@murilo09
Copy link
Contributor

I understand, u can make a PR with the changes, but i thought u were asking about the calculation.

Or if u rather I could do it

It’s just showing the wrong value, but it’s correct. Remove the chance from items.xml

Thanks for your help!

@Maska1991
Copy link

after this change i can't compile.
C2039 - „createItemBatch”
C2661 - "Item::CreateItem"
C2511 - „std::shared_ptr Item::CreateItem(const uint16_t,uint16_t,Position *,bool,bool)”:

@dudantas
Copy link
Member

after this change i can't compile. C2039 - „createItemBatch” C2661 - "Item::CreateItem" C2511 - „std::shared_ptr Item::CreateItem(const uint16_t,uint16_t,Position *,bool,bool)”:

It doesn't make sense, this pull request doesn't even have those changes. It looks like you mixed different pulls and probably did something wrong.

feliphechaves pushed a commit to feliphechaves/opentibiabr that referenced this issue May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Minor impact Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants