extract out RTC interaction code

:Release Notes:
Slight re-factoring/re-organization to ease further development.

:Detailed Notes:
Decompose timeout_alarm to have separate module for time change
handling. Note that no actual changes were made in code.

:Testing Performed:
- desktop build

:QA Notes:

:Issues Addressed:
[GF-6704] sleepd daemon looks unhappy

Open-webOS-DCO-1.0-Signed-off-by: Nikolay Orliuk <[email protected]>

Change-Id: I2c55544d067b6c6a0b920003703354e9f6985d1c
Reviewed-on: https://g2g.palm.com/3859
Reviewed-by: Nikolay Orliuk <[email protected]>
Reviewed-by: Build Verification
Reviewed-by: Keith Derrick <[email protected]>
Tested-by: Keith Derrick <[email protected]>

Author: Nikolay Orliuk

CMakeLists.txt

@@ -74,6 +74,7 @@ include_directories(${POWERD_INCLUDE_DIRS})
 webos_add_compiler_flags(ALL ${POWERD_CFLAGS_OTHER})
 
 webos_add_compiler_flags(ALL -Wall)
+webos_add_compiler_flags(ALL -Werror=implicit-function-declaration)
 
 # Allow developer to compile with -Werror, without potentially breaking a build
 set(WEBOS_USE_WERROR FALSE CACHE BOOL "Set to TRUE to enable -Werror")

include/internal/reference_time.h

@@ -0,0 +1,62 @@
+/****************************************************************
+ * @@@LICENSE
+ *
+ * Copyright (c) 2013 LG Electronics, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ * LICENSE@@@
+ ****************************************************************/
+
+/**
+ *  @file reference_time.h
+ *
+ *  Interfece to some reference time source built to address issues caused by
+ *  system time change.
+ */
+
+#ifndef __REFERENCE_TIME_H
+#define __REFERENCE_TIME_H
+
+#include <stdbool.h>
+#include <time.h>
+
+/**
+ * @brief Convert to rtc time.
+ *
+ * @param  t
+ *
+ * @retval
+ */
+time_t to_rtc(time_t t);
+
+/**
+ * @brief Last wall time.
+ *
+ * @retval
+ */
+time_t rtc_wall_time(void);
+
+/**
+ * @brief Calculate the time difference between RTC time and wall time
+ */
+bool wall_rtc_diff(time_t *ret_delta);
+
+/**
+ * @brief Update the rtc and return the difference rtc changed by.
+ *
+ * @retval
+ */
+time_t update_rtc(time_t *ret_delta);
+
+#endif

src/alarms/reference_time.c

@@ -0,0 +1,92 @@
+/****************************************************************
+ * @@@LICENSE
+ *
+ * Copyright (c) 2013 LG Electronics, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ * LICENSE@@@
+ ****************************************************************/
+
+/**
+ *  @file reference_time.c
+ *
+ *  Implmenetation of reference time source
+ */
+
+#include <nyx/nyx_client.h>
+
+#include "main.h"
+#include "reference_time.h"
+
+static time_t rtc_to_wall = 0;
+
+time_t to_rtc(time_t t)
+{
+	return t - rtc_to_wall;
+}
+
+time_t rtc_wall_time(void)
+{
+	time_t rtctime = 0;
+	nyx_system_query_rtc_time(GetNyxSystemDevice(), &rtctime);
+	return rtctime + rtc_to_wall;
+}
+
+bool
+wall_rtc_diff(time_t *ret_delta)
+{
+	time_t rtc_time_now = 0;
+	time_t wall_time_now = 0;
+
+	nyx_system_query_rtc_time(GetNyxSystemDevice(), &rtc_time_now);
+
+	time(&wall_time_now);
+
+	/* Calculate the time difference */
+	time_t delta = wall_time_now - rtc_time_now;
+
+	if (ret_delta)
+	{
+		*ret_delta = delta;
+	}
+
+	return true;
+}
+
+time_t update_rtc(time_t *ret_delta)
+{
+	bool retVal;
+	time_t new_delta = 0;
+	time_t delta = 0;
+
+	retVal = wall_rtc_diff(&new_delta);
+
+	if (!retVal)
+	{
+		return false;
+	}
+
+	if (new_delta != rtc_to_wall)
+	{
+		delta = new_delta - rtc_to_wall;
+		rtc_to_wall = new_delta;
+	}
+
+	if (ret_delta)
+	{
+		*ret_delta = delta;
+	}
+
+	return true;
+}

src/alarms/timeout_alarm.c

@@ -40,6 +40,7 @@
 #include "lunaservice_utils.h"
 
 #include "timersource.h"
+#include "reference_time.h"
 
 #include "timeout_alarm.h"
 #include "config.h"
@@ -134,89 +135,6 @@ CREATE INDEX IF NOT EXISTS expiry_index on AlarmTimeout (expiry);";
  * @{
  */
 
-
-static time_t rtc_to_wall = 0;
-/**
-* @brief Convert to rtc time.
-*
-* @param  t
-*
-* @retval
-*/
-static time_t to_rtc(time_t t)
-{
-	return t - rtc_to_wall;
-}
-
-/**
-* @brief Last wall time.
-*
-* @retval
-*/
-time_t rtc_wall_time(void)
-{
-	time_t rtctime = 0;
-	nyx_system_query_rtc_time(GetNyxSystemDevice(), &rtctime);
-	return rtctime + rtc_to_wall;
-}
-
-/**
-* @brief Calculate the time difference between RTC time and wall time
-*/
-
-bool
-wall_rtc_diff(time_t *ret_delta)
-{
-	time_t rtc_time_now = 0;
-	time_t wall_time_now = 0;
-
-	nyx_system_query_rtc_time(GetNyxSystemDevice(), &rtc_time_now);
-
-	time(&wall_time_now);
-
-	/* Calculate the time difference */
-	time_t delta = wall_time_now - rtc_time_now;
-
-	if (ret_delta)
-	{
-		*ret_delta = delta;
-	}
-
-	return true;
-}
-
-/**
-* @brief Update the rtc and return the difference rtc changed by.
-*
-* @retval
-*/
-static time_t update_rtc(time_t *ret_delta)
-{
-	bool retVal;
-	time_t new_delta = 0;
-	time_t delta = 0;
-
-	retVal = wall_rtc_diff(&new_delta);
-
-	if (!retVal)
-	{
-		return false;
-	}
-
-	if (new_delta != rtc_to_wall)
-	{
-		delta = new_delta - rtc_to_wall;
-		rtc_to_wall = new_delta;
-	}
-
-	if (ret_delta)
-	{
-		*ret_delta = delta;
-	}
-
-	return true;
-}
-
 static void
 _print_timeout(const char *message, const char *app_id, const char *key,
                bool public_bus, time_t expiry)
@@ -1569,10 +1487,6 @@ _alarms_timeout_init(void)
 	{
 		SLEEPDLOG_ERROR(MSGID_UPDATE_RTC_FAIL, 0, "could not get wall-rtc offset");
 	}
-	else
-	{
-		SLEEPDLOG_DEBUG("Initial WALL-RTC = %ld", rtc_to_wall);
-	}
 
 	GTimerSource *timer_rtc_check = g_timer_source_new_seconds(5 * 60);
 	g_source_set_callback((GSource *)timer_rtc_check,