Skip to content

bug: Removed item still appears in Proposed Change diff #6379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BaptisteGi opened this issue Apr 30, 2025 · 0 comments · Fixed by #6391
Closed

bug: Removed item still appears in Proposed Change diff #6379

BaptisteGi opened this issue Apr 30, 2025 · 0 comments · Fixed by #6391
Assignees
Labels
group/backend Issue related to the backend (API Server, Git Agent) priority/2 This issue stalls work on the project or its dependents, it's a blocker for a release type/bug Something isn't working as expected

Comments

@BaptisteGi
Copy link
Contributor

Component

API Server / GraphQL

Infrahub version

1.2.7

Current Behavior

Assuming I opened a proposed change to get a branch merged toward main. While reviewing the diff in data I figure out that some data I added in that branch aren't relevant anymore. I browse to the object > delete > go back to the proposed change > refresh diff.

From here I can see two issues:

  • Deleted item is still in the diff even tho I requested multiple refresh
  • When I merge that branch into main, the item I deleted comes back from the dead

Expected Behavior

When an item is deleted it should be taken into account in the diff.

Steps to Reproduce

  • Spin infrahub
  • Create a branch
  • Create multiple tags on the branch
  • Create a proposed change
  • Diff looks like this
    Image
  • Still on the branch browse to the tag list and delete one of them
  • Refresh data diff on the proposed change => Can't see any change even tho my tag list looks like this
    Image
  • Merge the proposed change
  • Check the tags list on main branch
    Image

Additional Information

No response

@BaptisteGi BaptisteGi added group/backend Issue related to the backend (API Server, Git Agent) priority/2 This issue stalls work on the project or its dependents, it's a blocker for a release type/bug Something isn't working as expected labels Apr 30, 2025
@exalate-issue-sync exalate-issue-sync bot added state/need-triage This issue needs to be triaged priority/2 This issue stalls work on the project or its dependents, it's a blocker for a release and removed priority/2 This issue stalls work on the project or its dependents, it's a blocker for a release state/need-triage This issue needs to be triaged labels Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/backend Issue related to the backend (API Server, Git Agent) priority/2 This issue stalls work on the project or its dependents, it's a blocker for a release type/bug Something isn't working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants